Merge pull request #485 from puppetlabs/CAT-2222

(CAT-2222) Update legacy facts

Author: amitkarsale

lib/facter/sqlserver_features.rb

@@ -3,7 +3,7 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'puppet_x/sqlserver/features'))
 
 Facter.add(:sqlserver_features) do
-  confine osfamily: :windows
+  confine 'os.family': :windows
 
   setcode do
     PuppetX::Sqlserver::Features.features

lib/facter/sqlserver_instances.rb

@@ -3,7 +3,7 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'puppet_x/sqlserver/features'))
 
 Facter.add(:sqlserver_instances) do
-  confine osfamily: :windows
+  confine 'os.family': :windows
 
   setcode do
     PuppetX::Sqlserver::Features.instances

lib/puppet/provider/sqlserver.rb

@@ -6,7 +6,7 @@
 require 'tempfile'
 
 class Puppet::Provider::Sqlserver < Puppet::Provider # rubocop:disable Style/Documentation
-  confine operatingsystem: :windows
+  confine 'os.name': :windows
 
   initvars
 

spec/defines/config_spec.rb

@@ -5,7 +5,7 @@
 
 RSpec.describe 'sqlserver::config', type: :define do
   let(:title) { 'MSSQLSERVER' }
-  let(:facts) { { osfamily: 'windows', platform: 'windows', puppet_vardir: 'C:/ProgramData/PuppetLabs/puppet/var' } }
+  let(:facts) { { 'os.family': 'windows', platform: 'windows', puppet_vardir: 'C:/ProgramData/PuppetLabs/puppet/var' } }
 
   describe 'compile' do
     let(:params) do