Remove use of spec_helper_acceptance in unit tests

In c96b073 the acceptance helper was
included in the unit tests. This should never happen and breaks the
tests. It appears it was included to have a postgresql_version but that
should be defined in let blocks. The acceptance helper only works if
there is an actual target machine.

Fixes: c96b073

Author: ekohl

spec/unit/defines/server/default_privileges_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'spec_helper_acceptance'
 
 describe 'postgresql::server::default_privileges', type: :define do
   let :facts do
@@ -65,13 +64,11 @@
       "class {'postgresql::server':}"
     end
 
-    if Gem::Version.new(postgresql_version) >= Gem::Version.new('9.6')
-      it { is_expected.to compile.with_all_deps }
-      it { is_expected.to contain_postgresql__server__default_privileges('test') }
-      it do
-        is_expected.to contain_postgresql_psql('default_privileges:test')
-          .with_command('ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT ALL ON TABLES TO "test"')
-      end
+    it { is_expected.to compile.with_all_deps }
+    it { is_expected.to contain_postgresql__server__default_privileges('test') }
+    it do
+      is_expected.to contain_postgresql_psql('default_privileges:test')
+        .with_command('ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT ALL ON TABLES TO "test"')
     end
   end
 
@@ -90,9 +87,7 @@
         "class {'postgresql::server':}"
       end
 
-      if Gem::Version.new(postgresql_version) >= Gem::Version.new('9.6')
-        it { is_expected.to compile.and_raise_error(%r{parameter 'object_type' expects a match for Pattern}) }
-      end
+      it { is_expected.to compile.and_raise_error(%r{parameter 'object_type' expects a match for Pattern}) }
     end
   end
 
@@ -111,16 +106,14 @@
         "class {'postgresql::server':}"
       end
 
-      if Gem::Version.new(postgresql_version) >= Gem::Version.new('9.6')
-        it { is_expected.to compile.with_all_deps }
-        it { is_expected.to contain_postgresql__server__default_privileges('test') }
-        it do
-          # rubocop:disable Layout/LineLength
-          is_expected.to contain_postgresql_psql('default_privileges:test')
-            .with_command('ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT ALL ON TABLES TO "test"')
-            .with_unless("SELECT 1 WHERE EXISTS (SELECT * FROM pg_default_acl AS da JOIN pg_namespace AS n ON da.defaclnamespace = n.oid WHERE 'test=arwdDxt' = ANY (defaclacl) AND nspname = 'public' and defaclobjtype = 'r')")
-          # rubocop:enable Layout/LineLength
-        end
+      it { is_expected.to compile.with_all_deps }
+      it { is_expected.to contain_postgresql__server__default_privileges('test') }
+      it do
+        # rubocop:disable Layout/LineLength
+        is_expected.to contain_postgresql_psql('default_privileges:test')
+          .with_command('ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT ALL ON TABLES TO "test"')
+          .with_unless("SELECT 1 WHERE EXISTS (SELECT * FROM pg_default_acl AS da JOIN pg_namespace AS n ON da.defaclnamespace = n.oid WHERE 'test=arwdDxt' = ANY (defaclacl) AND nspname = 'public' and defaclobjtype = 'r')")
+        # rubocop:enable Layout/LineLength
       end
     end
 
@@ -138,9 +131,7 @@
         "class {'postgresql::server':}"
       end
 
-      if Gem::Version.new(postgresql_version) >= Gem::Version.new('9.6')
-        it { is_expected.to compile.and_raise_error(%r{Illegal value for \$privilege parameter}) }
-      end
+      it { is_expected.to compile.and_raise_error(%r{Illegal value for \$privilege parameter}) }
     end
   end
 
@@ -225,16 +216,14 @@
       "class {'postgresql::server':}"
     end
 
-    if Gem::Version.new(postgresql_version) >= Gem::Version.new('9.6')
-      it { is_expected.to compile.with_all_deps }
-      it { is_expected.to contain_postgresql__server__default_privileges('test') }
-      it do
-        # rubocop:disable Layout/LineLength
-        is_expected.to contain_postgresql_psql('default_privileges:test')
-          .with_command('ALTER DEFAULT PRIVILEGES IN SCHEMA my_schema GRANT ALL ON TABLES TO "test"')
-          .with_unless("SELECT 1 WHERE EXISTS (SELECT * FROM pg_default_acl AS da JOIN pg_namespace AS n ON da.defaclnamespace = n.oid WHERE 'test=arwdDxt' = ANY (defaclacl) AND nspname = 'my_schema' and defaclobjtype = 'r')")
-        # rubocop:enable Layout/LineLength
-      end
+    it { is_expected.to compile.with_all_deps }
+    it { is_expected.to contain_postgresql__server__default_privileges('test') }
+    it do
+      # rubocop:disable Layout/LineLength
+      is_expected.to contain_postgresql_psql('default_privileges:test')
+        .with_command('ALTER DEFAULT PRIVILEGES IN SCHEMA my_schema GRANT ALL ON TABLES TO "test"')
+        .with_unless("SELECT 1 WHERE EXISTS (SELECT * FROM pg_default_acl AS da JOIN pg_namespace AS n ON da.defaclnamespace = n.oid WHERE 'test=arwdDxt' = ANY (defaclacl) AND nspname = 'my_schema' and defaclobjtype = 'r')")
+      # rubocop:enable Layout/LineLength
     end
   end
 
@@ -255,14 +244,12 @@ class {'postgresql::server':}
       EOS
     end
 
-    if Gem::Version.new(postgresql_version) >= Gem::Version.new('9.6')
-      it { is_expected.to compile.with_all_deps }
-      it { is_expected.to contain_postgresql__server__default_privileges('test') }
-      it { is_expected.to contain_postgresql__server__role('test') }
-      it do
-        is_expected.to contain_postgresql_psql('default_privileges:test') \
-          .that_requires(['Service[postgresqld]', 'Postgresql::Server::Role[test]'])
-      end
+    it { is_expected.to compile.with_all_deps }
+    it { is_expected.to contain_postgresql__server__default_privileges('test') }
+    it { is_expected.to contain_postgresql__server__role('test') }
+    it do
+      is_expected.to contain_postgresql_psql('default_privileges:test') \
+        .that_requires(['Service[postgresqld]', 'Postgresql::Server::Role[test]'])
     end
   end