added default setting for path

* postgresql::server::config_entry in postgresql::server::instance::config
* easier path management in postgresql::server::config_entry

Author: SimonHoenscheid

manifests/server/config_entry.pp

@@ -9,15 +9,8 @@
   Enum['present', 'absent']                               $ensure = 'present',
   String[1]                                               $key    = $name,
   Optional[Variant[String[1], Numeric, Array[String[1]]]] $value  = undef,
-  Variant[Boolean, String[1]]                             $path   = false
+  Variant[Boolean, String[1]]                             $path   = $postgresql::server::postgresql_conf_path
 ) {
-  $postgresql_conf_path = $postgresql::server::postgresql_conf_path
-
-  $target = $path ? {
-    false   => $postgresql_conf_path,
-    default => $path,
-  }
-
   # Those are the variables that are marked as "(change requires restart)"
   # on postgresql.conf.  Items are ordered as on postgresql.conf.
   #
@@ -91,7 +84,7 @@
 
   postgresql_conf { $name:
     ensure  => $ensure,
-    target  => $target,
+    target  => $path,
     name    => $key,
     value   => $value,
     require => Class['postgresql::server::initdb'],

manifests/server/instance/config.pp

@@ -148,6 +148,11 @@
       }
     }
   }
+  # set default postgresql_conf_path here so the path is configurable in instances for
+  # default values like port or listen_address
+  Postgresql::Server::Config_entry {
+    path => $postgresql_conf_path,
+  }
 
   if $manage_postgresql_conf_perms {
     file { $postgresql_conf_path: