Formatting and Refactoring Changes to Vars

Author: Aaronoftheages

manifests/pg_repack.pp

@@ -8,23 +8,24 @@
 # @param activity_tables [Array] Array of 'activity' tables to repack
 # @param disable_maintenance [Boolean] true or false (Default: false)
 #   Disable or enable maintenance mode
+# @param repack_log_level [Enum] Desired output level of logs
+# @param enable_echo [Boolean] true or false (Default: true)
+#   Enabling echo output in logs
 # @param jobs [Integer] How many jobs to run in parallel
 # @param facts_tables_repack_timer [String] The Systemd timer for the pg_repack job affecting the 'facts' tables
 # @param catalogs_tables_repack_timer [String]The Systemd timer for the pg_repack job affecting the 'catalog' tables
 # @param other_tables_repack_timer [String] The Systemd timer for the pg_repack job affecting the 'other' tables
 # @param activity_tables_repack_timer [String] The Systemd timer for the pg_repack job affecting the 'activity' tables
 # @param reports_tables_repack_timer [String] Deprecated Parameter will be removed in future releases
 # @param resource_events_tables_repack_timer [String] Deprecated Parameter will be removed in future releases
-# @param repack_run_level 
-# @param enable_echo
 class pe_databases::pg_repack (
   # Provided by module data
   Array $fact_tables,
   Array $catalog_tables,
   Array $other_tables,
   Array $activity_tables,
   Boolean $disable_maintenance = false,
-  Enum['INFO','NOTICE','WARNING', 'ERROR', 'LOG', 'FATAL','PANIC','DEBUG'] $repack_run_level='DEBUG',
+  Enum['INFO','NOTICE','WARNING','ERROR','LOG','FATAL','PANIC','DEBUG'] $repack_log_level='DEBUG',
   Boolean $enable_echo = true,
   Integer $jobs = $facts['processors']['count'] / 4,
   String[1] $facts_tables_repack_timer = $pe_databases::facts_tables_repack_timer,
@@ -40,14 +41,11 @@
   $postgresql_version = $facts['pe_postgresql_info']['installed_server_version']
   $repack_executable = "/opt/puppetlabs/server/apps/postgresql/${postgresql_version}/bin/pg_repack"
 
-  #Add conditionals, 
-  #If echo enabled = true run WITH 
   if $enable_echo {
     $repack_cmd = "${repack_executable} --jobs ${jobs} --elevel ${repack_run_level} --echo"
   } else {
     $repack_cmd = "${repack_executable} --jobs ${jobs} --elevel ${repack_run_level}"
   }
-  #else echo ommited - run without echo 
 
   pe_databases::collect { 'facts':
     disable_maintenance => $disable_maintenance,