Fix scope of disable_maintenance param

Prior to this commit, the disable_maintenance param was part of a
maintenance class that had been removed.  This commit fixes that and
moves the lookup to the param definition.

Author: m0dular

README.md

@@ -68,7 +68,7 @@ You can configure the retention policy by setting `pe_databases::backup::retenti
 The maintenance cron jobs will perform a `VACUUM FULL` on various `pe-puppetdb` tables to keep them lean and fast.
 A `VACUUM FULL` is a blocking operation and you will see the PuppetDB command queue grow while the cron jobs run.
 The blocking should be short lived and the PuppetDB command queue should work itself down after, however, if for some reason you experience issues you can disable the maintenance cron jobs.
-You can do so by setting `pe_databases::maintenance::disable_maintenance: true` in your hieradata.
+You can do so by setting `pe_databases::disable_maintenance: true` in your hieradata.
 
 With PE 2018.1.7 and 2019.0.2 and newer, this module uses `pg_repack` which does not block.
 

manifests/init.pp

@@ -4,7 +4,10 @@
 
 class pe_databases (
   Boolean $manage_database_backups     = false,
+  # Manage the inclusion of the pg_repack class
   Boolean $manage_database_maintenance = true,
+  # Manage the state of the maintenance tasks, i.e. systemd services and timers
+  Boolean $disable_maintenance         = lookup('pe_databases::disable_maintenance', {'default_value' => false}),
   Boolean $manage_postgresql_settings  = true,
   Boolean $manage_table_settings       = true,
   String  $install_dir                 = '/opt/puppetlabs/pe_databases',
@@ -30,7 +33,7 @@
   if $facts.dig('pe_databases', 'have_systemd') {
     if $manage_database_maintenance and (versioncmp('2019.0.2', $facts['pe_server_version']) <= 0) {
       class {'pe_databases::pg_repack':
-        disable_maintenance => lookup('pe_databases::maintenance::disable_maintenance', {'default_value' => false}),
+        disable_maintenance => $disable_maintenance,
       }
       if $manage_table_settings {
         # This is to provide for situations, like PE XL,