From 9580f0f4f721d47e86204f52ab5c907bfd32e969 Mon Sep 17 00:00:00 2001 From: devcfgc Date: Thu, 15 Jun 2017 12:31:13 +0200 Subject: [PATCH 1/2] Puppet 4 introduces strong type checking so after this change it should work on puppet 4 and puppet 3 --- manifests/params.pp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifests/params.pp b/manifests/params.pp index cb1e6b22d..86b2f73fc 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -385,7 +385,7 @@ case $::operatingsystem { 'Ubuntu': { - if versioncmp($::operatingsystemmajrelease, '14.10') > 0 { + if versioncmp("${::operatingsystemmajrelease}", '14.10') > 0 { $server_service_provider = 'systemd' } else { $server_service_provider = 'upstart' From 2ad960d5363f008e4f05cbe7224b1e2836884ca9 Mon Sep 17 00:00:00 2001 From: devcfgc Date: Thu, 15 Jun 2017 13:07:24 +0200 Subject: [PATCH 2/2] Add lint:ignore:only_variable_string --- manifests/params.pp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/manifests/params.pp b/manifests/params.pp index 86b2f73fc..ca8c52011 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -385,7 +385,9 @@ case $::operatingsystem { 'Ubuntu': { + # lint:ignore:only_variable_string if versioncmp("${::operatingsystemmajrelease}", '14.10') > 0 { + # lint:endignore $server_service_provider = 'systemd' } else { $server_service_provider = 'upstart'