top-scope facts

Author: LukasAud

.puppet-lint.rc

@@ -1,4 +1,3 @@
 --relative
---no-top_scope_facts-check
 --no-anchor_resource-check
 --no-params_empty_string_assignment-check

.sync.yml

@@ -36,6 +36,5 @@ Rakefile:
 changelog_since_tag: 'v11.0.3'
 Rakefile:
   extra_disabled_lint_checks:
-    - top_scope_facts
     - anchor_resource
     - params_empty_string_assignment

Rakefile

@@ -42,7 +42,6 @@ def changelog_future_release
 end
 
 PuppetLint.configuration.send('disable_relative')
-PuppetLint.configuration.send('disable_top_scope_facts')
 PuppetLint.configuration.send('disable_anchor_resource')
 PuppetLint.configuration.send('disable_params_empty_string_assignment')
 

manifests/db.pp

@@ -126,7 +126,7 @@
       exec { "${dbname}-import":
         command     => "${import_cat_cmd} ${shell_join($sql)} | mysql ${dbname}",
         logoutput   => true,
-        environment => "HOME=${::root_home}",
+        environment => "HOME=${facts['root_home']}",
         refreshonly => ! $enforce_sql,
         path        => "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:${_mysql_exec_path}",
         require     => Mysql_grant["${user}@${host}/${table}"],

manifests/server/root_password.pp

@@ -39,23 +39,23 @@
 
   if $mysql::server::create_root_my_cnf and $root_password_set {
     # TODO: use EPP instead of ERB, as EPP can handle Data of Type Sensitive without further ado
-    file { "${::root_home}/.my.cnf":
+    file { "${facts['root_home']}/.my.cnf":
       content => template('mysql/my.cnf.pass.erb'),
       owner   => 'root',
       mode    => '0600',
     }
 
     # show_diff was added with puppet 3.0
-    if versioncmp($::puppetversion, '3.0') >= 0 {
-      File["${::root_home}/.my.cnf"] { show_diff => false }
+    if versioncmp($facts['puppetversion'], '3.0') >= 0 {
+      File["${facts['root_home']}/.my.cnf"] { show_diff => false }
     }
     if $mysql::server::create_root_user {
-      Mysql_user['root@localhost'] -> File["${::root_home}/.my.cnf"]
+      Mysql_user['root@localhost'] -> File["${facts['root_home']}/.my.cnf"]
     }
   }
 
   if $mysql::server::create_root_login_file and $root_password_set {
-    file { "${::root_home}/.mylogin.cnf":
+    file { "${facts['root_home']}/.mylogin.cnf":
       source => $login_file,
       owner  => 'root',
       mode   => '0600',