Merge pull request #961 from eputnam/MODULES-4896

(MODULES-4604) move name validation in mysql_grant type

Author: hunner

lib/puppet/type/mysql_grant.rb

@@ -34,7 +34,9 @@ def initialize(*args)
     fail('PROXY must be the only privilege specified.') if Array(self[:privileges]).count > 1 and Array(self[:privileges]).include?('PROXY')
     fail('table parameter is required.') if self[:ensure] == :present and self[:table].nil?
     fail('user parameter is required.') if self[:ensure] == :present and self[:user].nil?
-    fail('name must match user and table parameters') if self[:name] != "#{self[:user]}/#{self[:table]}"
+    if self[:user] and self[:table]
+      fail('name must match user@host/table format') if self[:name] != "#{self[:user]}/#{self[:table]}"
+    end
   end
 
   newparam(:name, :namevar => true) do

spec/acceptance/types/mysql_grant_spec.rb

@@ -109,25 +109,6 @@ class { 'mysql::server':
     end
   end
 
-  describe 'adding privileges with invalid name' do
-    it 'should fail' do
-      pp = <<-EOS
-        mysql_user { 'test2@tester':
-          ensure => present,
-        }
-        mysql_grant { 'test':
-          ensure     => 'present',
-          table      => 'test.*',
-          user       => 'test2@tester',
-          privileges => ['SELECT', 'UPDATE'],
-          require    => Mysql_user['test2@tester'],
-        }
-      EOS
-
-      expect(apply_manifest(pp, :expect_failures => true).stderr).to match(/name must match user and table parameters/)
-    end
-  end
-
   describe 'adding option' do
     it 'should work without errors' do
       pp = <<-EOS

spec/unit/puppet/type/mysql_grant_spec.rb

@@ -67,9 +67,12 @@
   end
 
   it 'should require the name to match the user and table' do
+    expect {
+      Puppet::Type.type(:mysql_grant).new(:name => 'foo@localhost/*.*', :privileges => ['ALL'], :table => ['*.*'], :user => 'foo@localhost')
+    }.to_not raise_error
     expect {
       Puppet::Type.type(:mysql_grant).new(:name => 'foo', :privileges => ['ALL'], :table => ['*.*'], :user => 'foo@localhost')
-    }.to raise_error /name must match user and table parameters/
+    }.to raise_error /name must match user@host\/table format/
   end
 
   describe 'it should munge privileges' do