Merge pull request #987 from joshuaspence/ordering

Ensure that Puppet runs are idempotent

Author: david22swan

manifests/server.pp

@@ -76,8 +76,8 @@
   }
 
   Anchor['mysql::server::start']
-  -> Class['mysql::server::config']
   -> Class['mysql::server::install']
+  -> Class['mysql::server::config']
   -> Class['mysql::server::binarylog']
   -> Class['mysql::server::installdb']
   -> Class['mysql::server::service']

spec/acceptance/mysql_server_spec.rb

@@ -3,14 +3,9 @@
 describe 'mysql class' do
   # rubocop:disable RSpec/InstanceVariable
   describe 'advanced config' do
-    before(:all) do
-      @tmpdir = default.tmpdir('mysql')
-    end
     let(:pp) do
       <<-MANIFEST
         class { 'mysql::server':
-          config_file             => '#{@tmpdir}/my.cnf',
-          includedir              => '#{@tmpdir}/include',
           manage_config_file      => 'true',
           override_options        => { 'mysqld' => { 'key_buffer_size' => '32M' }},
           package_ensure          => 'present',
@@ -59,8 +54,6 @@ class { 'mysql::server':
     let(:pp) do
       <<-MANIFEST
         class { 'mysql::server':
-          config_file             => '#{@tmpdir}/my.cnf',
-          includedir              => '#{@tmpdir}/include',
           manage_config_file      => 'false',
           override_options        => { 'mysqld' => { 'key_buffer_size' => '32M' }},
           package_ensure          => 'present',