Skip to content

Commit 4f15b1b

Browse files
committed
Ubuntu 20.04 using mariadb defaults to utf8
1 parent a1d20a7 commit 4f15b1b

6 files changed

+4
-23
lines changed

spec/acceptance/00_mysql_server_spec.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ class { 'mysql::server':
3838
},
3939
databases => {
4040
'somedb' => {
41-
ensure => 'present',
42-
charset => #{fetch_charset},
41+
ensure => 'present',
4342
},
4443
}
4544
}

spec/acceptance/01_mysql_db_spec.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ class { 'mysql::server':
1414
mysql::db { 'spec1':
1515
user => 'root1',
1616
password => 'password',
17-
charset => #{fetch_charset},
1817
}
1918
MANIFEST
2019
end
@@ -43,7 +42,6 @@ class { 'mysql::server': override_options => { 'root_password' => 'password' } }
4342
user => 'root1',
4443
password => 'password',
4544
sql => '/tmp/spec.sql',
46-
charset => #{fetch_charset},
4745
}
4846
MANIFEST
4947
end
@@ -68,7 +66,6 @@ class { 'mysql::server': override_options => { 'root_password' => 'password' } }
6866
user => 'root1',
6967
password => 'password',
7068
dbname => 'realdb',
71-
charset => #{fetch_charset},
7269
}
7370
MANIFEST
7471
end

spec/acceptance/04_mysql_backup_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ class { 'mysql::server': root_password => 'password' }
1212
]:
1313
user => 'backup',
1414
password => 'secret',
15-
charset => #{fetch_charset},
1615
}
1716
1817
class { 'mysql::server::backup':
@@ -73,7 +72,6 @@ class { 'mysql::server': root_password => 'password' }
7372
]:
7473
user => 'backup',
7574
password => 'secret',
76-
charset => #{fetch_charset},
7775
}
7876
7977
class { 'mysql::server::backup':
@@ -138,7 +136,6 @@ class { 'mysql::server': root_password => 'password' }
138136
]:
139137
user => 'backup',
140138
password => 'secret',
141-
charset => #{fetch_charset},
142139
}
143140
case $facts['os']['family'] {
144141
/Debian/: {
@@ -259,7 +256,6 @@ class { 'mysql::server': root_password => 'password' }
259256
]:
260257
user => 'backup',
261258
password => 'secret',
262-
charset => #{fetch_charset},
263259
}
264260
case $facts['os']['family'] {
265261
/Debian/: {

spec/acceptance/types/mysql_database_spec.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ class { 'mysql::server': }
1515
describe 'creating database' do
1616
pp = <<-MANIFEST
1717
mysql_database { 'spec_db':
18-
ensure => present,
19-
charset => #{fetch_charset},
18+
ensure => present,
2019
}
2120
MANIFEST
2221
it 'works without errors' do
@@ -38,7 +37,7 @@ class { 'mysql::server': }
3837
collate => 'latin1_swedish_ci',
3938
}
4039
mysql_database { 'spec_utf8':
41-
charset => #{fetch_charset},
40+
charset => 'utf8',
4241
collate => 'utf8_general_ci',
4342
}
4443
MANIFEST

spec/acceptance/types/mysql_grant_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,7 @@ class { 'mysql::server':
273273
$dbSubnet = '10.10.10.%'
274274
275275
mysql_database { 'foo':
276-
ensure => present,
277-
charset => '#{fetch_charset}',
276+
ensure => present,
278277
}
279278
280279
exec { 'mysql-create-table':
@@ -686,7 +685,6 @@ class { 'mysql::server': override_options => { 'root_password' => 'password' } }
686685
user => 'root1',
687686
password => 'password',
688687
sql => '/tmp/grant_spec_table.sql',
689-
charset => #{fetch_charset},
690688
}
691689
MANIFEST
692690
it 'creates table' do

spec/spec_helper_acceptance_local.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,6 @@ def export_locales
3232
LitmusHelper.instance.run_shell('. ~/.bashrc')
3333
end
3434

35-
def fetch_charset
36-
@charset ||= if os[:family] == 'ubuntu' && os[:release] =~ %r{^20\.04}
37-
'utf8mb3'
38-
else
39-
'utf8'
40-
end
41-
end
42-
4335
RSpec.configure do |c|
4436
c.before :suite do
4537
if os[:family] == 'debian' || os[:family] == 'ubuntu'

0 commit comments

Comments
 (0)