Rely on latest stdlib for proper powershell escaping

Author: smortex

lib/puppet/parser/functions/docker_run_flags.rb

@@ -9,7 +9,7 @@ module Puppet::Parser::Functions
     subject = args[0]
 
     if self['facts'] && self['facts']['os']['family'] == 'windows'
-      %("#{subject.gsub('"', '\\"')}")
+      call_function('powershell_escape', subject)
     else
       subject.shellescape
     end

metadata.json

@@ -10,7 +10,7 @@
   "dependencies": [
     {
       "name": "puppetlabs/stdlib",
-      "version_requirement": ">= 4.24.0 < 9.0.0"
+      "version_requirement": ">= 8.2.0 < 9.0.0"
     },
     {
       "name": "puppetlabs/apt",

spec/unit/lib/puppet/parser/functions/docker_run_flags_spec.rb

@@ -1,6 +1,10 @@
 require 'spec_helper'
 
 describe 'the "docker_run_flags" parser function' do
+  before :each do
+    Puppet[:modulepath] = "spec/fixtures/modules/"
+  end
+
   let :scope do
     node     = Puppet::Node.new('localhost')
     compiler = Puppet::Parser::Compiler.new(node)
@@ -22,7 +26,7 @@
     let(:os_family) { 'windows' }
 
     it 'escapes special chars' do
-      expect(scope.function_docker_run_flags([{ 'env' => [%.MYSQL_PASSWORD='"$()[]{}<>.], 'extra_params' => [] }])).to eq(%^-e "MYSQL_PASSWORD='\\"$()[]{}<>" \\\n^)
+      expect(scope.function_docker_run_flags([{ 'env' => [%.MYSQL_PASSWORD='"$()[]{}<>.], 'extra_params' => [] }])).to eq(%^-e MYSQL_PASSWORD=`'\\`"`$()[]{}<> \\\n^)
     end
   end
 end