CAT-1347 resolving review comments

Author: Dinesh Gujar

manifests/vhost.pp

@@ -2409,6 +2409,12 @@
     content => "  ServerSignature Off\n",
   }
 
+  # Template uses:
+  # - $_access_logs
+  # - $_access_log_env_var
+  # - $access_log_destination
+  # - $_access_log_format
+  # - $_access_log_env_var
   if !empty($_access_logs) {
     concat::fragment { "${name}-access_log":
       target  => "${priority_real}${filename}.conf",
@@ -2425,6 +2431,8 @@
     }
   }
 
+  # Template uses:
+  # - $block
   if $block and ! empty($block) {
     concat::fragment { "${name}-block":
       target  => "${priority_real}${filename}.conf",
@@ -2433,6 +2441,8 @@
     }
   }
 
+  # Template uses:
+  # - $error_documents
   if $error_documents and ! empty($error_documents) {
     concat::fragment { "${name}-error_document":
       target  => "${priority_real}${filename}.conf",
@@ -2514,6 +2524,19 @@
     }
   }
 
+  # Template uses:
+  # - $redirect_source
+  # - $redirect_dest
+  # - $redirect_status
+  # - $redirect_dest_a
+  # - $redirect_source_a
+  # - $redirect_status_a
+  # - $redirectmatch_status
+  # - $redirectmatch_regexp
+  # - $redirectmatch_dest
+  # - $redirectmatch_status_a
+  # - $redirectmatch_regexp_a
+  # - $redirectmatch_dest
   if (($redirect_source and $redirect_dest) or ($redirectmatch_regexp and $redirectmatch_dest)) and $ensure == 'present' {
     include apache::mod::alias
 
@@ -2524,6 +2547,13 @@
     }
   }
 
+  # Template uses:
+  # - $rewrites
+  # - $rewrite_inherit
+  # - $rewrite_base
+  # - $rewrite_rule
+  # - $rewrite_cond
+  # - $rewrite_map
   if (! empty($rewrites) or $rewrite_rule or $rewrite_inherit) and $ensure == 'present' {
     include apache::mod::rewrite
     $rewrite_params = {
@@ -2557,6 +2587,10 @@
     }
   }
 
+  # Template uses:
+  # - $setenv
+  # - $setenvif
+  # - $setenvifnocase
   $use_env_mod = !empty($setenv)
   $use_setenvif_mod = !empty($setenvif) or !empty($setenvifnocase)
   if ($use_env_mod or $use_setenvif_mod) and $ensure == 'present' {
@@ -2574,6 +2608,25 @@
     }
   }
 
+  # Template uses:
+  # - $ssl
+  # - $ssl_cert
+  # - $ssl_key
+  # - $ssl_chain
+  # - $ssl_certs_dir
+  # - $ssl_ca
+  # - $ssl_crl_path
+  # - $ssl_crl
+  # - $ssl_crl_check
+  # - $ssl_protocol
+  # - $ssl_cipher
+  # - $_ssl_honorcipherorder
+  # - $ssl_verify_client
+  # - $ssl_verify_depth
+  # - $ssl_options
+  # - $ssl_openssl_conf_cmd
+  # - $ssl_stapling
+  # - $mdomain
   if $ssl and $ensure == 'present' {
     include apache::mod::ssl
 
@@ -2623,6 +2676,9 @@
     }
   }
 
+  # Template uses:
+  # - $php_values
+  # - $php_flags
   if ($php_values and ! empty($php_values)) or ($php_flags and ! empty($php_flags)) {
     concat::fragment { "${name}-php":
       target  => "${priority_real}${filename}.conf",
@@ -2631,6 +2687,9 @@
     }
   }
 
+  # Template uses:
+  # - $php_admin_values
+  # - $php_admin_flags
   if ($php_admin_values and ! empty($php_admin_values)) or ($php_admin_flags and ! empty($php_admin_flags)) {
     concat::fragment { "${name}-php_admin":
       target  => "${priority_real}${filename}.conf",
@@ -2664,6 +2723,8 @@
     }
   }
 
+  # Template uses:
+  # - $custom_fragment
   if $custom_fragment {
     $custom_fragment_params = {
       'custom_fragment' => $custom_fragment,