(PDOC-226) Refactor Markdown testing

Previously the markdown unit testing used an a simple if statement to switch
between common and Puppet Plans.  However with the introduction of Puppet Types
we need another combination.  This commit refactors the Markdown testing use an
additive style to figure out test fixtures which makes adding conditional tests
easier in the future.

Author: glennsarti

spec/unit/puppet-strings/markdown_spec.rb

@@ -4,7 +4,7 @@
 require 'tempfile'
 
 describe PuppetStrings::Markdown do
-  before :each do
+  def parse_shared_content
     # Populate the YARD registry with both Puppet and Ruby source
     YARD::Parser::SourceParser.parse_string(<<-SOURCE, :puppet)
 # An overview for a simple class.
@@ -64,14 +64,6 @@ class noparams () {}
   String $param3 = 'hi',
   Boolean $param4 = true
 ) {
-}
-    SOURCE
-    YARD::Parser::SourceParser.parse_string(<<-SOURCE, :puppet) if TEST_PUPPET_PLANS
-# A simple plan.
-# @param param1 First param.
-# @param param2 Second param.
-# @param param3 Third param.
-plan plann(String $param1, $param2, Integer $param3 = 1) {
 }
     SOURCE
 
@@ -275,21 +267,48 @@ class noparams () {}
     SOURCE
   end
 
-  let(:filename) do
-    if TEST_PUPPET_PLANS
-      'output_with_plan.md'
-    else
-      'output.md'
-    end
+  def parse_plan_content
+    YARD::Parser::SourceParser.parse_string(<<-SOURCE, :puppet)
+# A simple plan.
+# @param param1 First param.
+# @param param2 Second param.
+# @param param3 Third param.
+plan plann(String $param1, $param2, Integer $param3 = 1) {
+}
+    SOURCE
   end
+
   let(:baseline_path) { File.join(File.dirname(__FILE__), "../../fixtures/unit/markdown/#{filename}") }
   let(:baseline) { File.read(baseline_path) }
 
   describe 'rendering markdown to a file' do
-    it 'should output the expected markdown content' do
-      Tempfile.open('md') do |file|
-        PuppetStrings::Markdown.render(file.path)
-        expect(File.read(file.path)).to eq(baseline)
+    before(:each) do
+      parse_shared_content
+    end
+
+    context 'with common Puppet and ruby content' do
+      let(:filename) { 'output.md' }
+
+      it 'should output the expected markdown content' do
+        Tempfile.open('md') do |file|
+          PuppetStrings::Markdown.render(file.path)
+          expect(File.read(file.path)).to eq(baseline)
+        end
+      end
+    end
+
+    describe 'with Puppet Plans', :if => TEST_PUPPET_PLANS do
+      let(:filename) { 'output_with_plan.md' }
+
+      before(:each) do
+        parse_plan_content
+      end
+
+      it 'should output the expected markdown content' do
+        Tempfile.open('md') do |file|
+          PuppetStrings::Markdown.render(file.path)
+          expect(File.read(file.path)).to eq(baseline)
+        end
       end
     end
   end