Skip to content

Commit 0edba81

Browse files
authored
fix: pubnub.yml validation issues (#39)
* fix: pubnub.yml validation issues * fix: race condition in subscribeSpec * buiild: remove SourceClear * build: update node * build: update yarn.lock * fix: update pubnub.yml date format
1 parent b704d40 commit 0edba81

File tree

4 files changed

+4810
-2399
lines changed

4 files changed

+4810
-2399
lines changed

.pubnub.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,17 @@ changelog:
1010
changes:
1111
- type: improvement
1212
text: update dependencies
13-
date: Dec 21, 2018
13+
date: 2018-12-21
1414
- version: v1.3.1
1515
changes:
1616
- type: bug
1717
text: add functions to (fetchMessages and deleteMessages) to declaration files for TS
18+
date: 2018-08-06
1819
- version: v1.3.0
1920
changes:
2021
- type: feature
2122
text: add functions to (fetchMessages and deleteMessages) and keep the stack of messages with only the latest 100
22-
date: Nov 28, 2017
23+
date: 2017-11-28
2324
- version: v1.2.0
2425
changes:
2526
- type: feature

.travis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
language: node_js
22
sudo: false
33
node_js:
4-
- '6'
4+
- '10'
55
env:
66
- CXX=g++-4.8
77
addons:
8-
srcclr: true
98
apt:
109
sources:
1110
- ubuntu-toolchain-r-test

test/e2e/subscribeSpec.test.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,19 @@ describe('#subscribe()', function () {
8888
pubnub.getInstance('another2').init(config.demo);
8989

9090
listener = {
91-
message: function (m) {
92-
expect(m.message).to.be.equal(stringMessage);
93-
done();
94-
}
95-
};
91+
message: function (m) {
92+
expect(m.message).to.be.equal(stringMessage);
93+
done();
94+
},
95+
status: function (st) {
96+
expect(st.category).to.be.equal("PNConnectedCategory");
97+
pubnub.getInstance('another2').publish({channel: channelName, message: stringMessage});
98+
},
99+
};
96100

97101
pubnub.getInstance('another2').addListener(listener);
98102

99103
pubnub.getInstance('another2').subscribe({channels: [channelName]});
100-
101-
pubnub.getInstance('another2').publish({channel: channelName, message: stringMessage});
102104
});
103105
});
104106

0 commit comments

Comments
 (0)