Skip to content

Commit f01caa3

Browse files
authored
update proxify links in developer pages (#6)
* update proxify links in developer pages * remove unnecessary commas and semicolons * rename developer image component
1 parent 9fcaa30 commit f01caa3

File tree

8 files changed

+60
-58
lines changed

8 files changed

+60
-58
lines changed

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
.DS_Store
44
.AppleDouble
55
.LSOverride
6-
.idea
76

87
# Thumbnails
98
._*
@@ -111,3 +110,6 @@ src/api/index.json
111110
src/examples/data.json
112111
src/tutorial/data.json
113112
draft.md
113+
114+
# folders created by IDE
115+
.idea

src/developers/components/DeveloperCard.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import { DeveloperProfile } from './type'
33
import { truncateTextFromArray } from './utils'
44
import { VTIconMapPin } from '@vue/theme'
5-
import CloudinaryImage from './CloudinaryImage.vue'
5+
import DeveloperImage from './DeveloperImage.vue'
66
import DeveloperProficiencies from './DeveloperProficiencies.vue'
77
import DeveloperCompensations from './DeveloperCompensations.vue'
88
@@ -27,7 +27,7 @@ const trimmedDescription = truncateTextFromArray(description, 220)
2727
>
2828
<div class="developer-card__header">
2929
<div v-if="!hero && profileImage" class="developer-card__avatar">
30-
<CloudinaryImage
30+
<DeveloperImage
3131
:src="profileImage"
3232
:alt="name"
3333
:width="120"
@@ -67,7 +67,7 @@ const trimmedDescription = truncateTextFromArray(description, 220)
6767
/>
6868

6969
<div v-if="hero && profileImage" class="developer-card__image">
70-
<CloudinaryImage
70+
<DeveloperImage
7171
:src="profileImage"
7272
:alt="name"
7373
:width="526"

src/developers/components/CloudinaryImage.vue renamed to src/developers/components/DeveloperImage.vue

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,23 @@
22
import { computed } from 'vue'
33
import partnerConfig from '../partnerConfig.js'
44
5-
const { cloudinaryUrl } = partnerConfig
5+
const { imageStorageUrl } = partnerConfig
66
77
const props = withDefaults(defineProps<{
8-
src: string,
9-
alt: string,
10-
width: number,
11-
height: number,
12-
quality?: string,
13-
crop?: string,
14-
faceRecognition?: boolean,
15-
loading?: 'lazy' | 'eager',
16-
className?: string,
8+
src: string
9+
alt: string
10+
width: number
11+
height: number
12+
quality?: string
13+
crop?: string
14+
faceRecognition?: boolean
15+
loading?: 'lazy' | 'eager'
16+
className?: string
1717
}>(), {
1818
quality: 'q_auto:best',
1919
crop: 'c_fit',
20-
faceRecognition: false,
21-
});
20+
faceRecognition: false
21+
})
2222
2323
const imageSrc = computed(() => {
2424
const attributes = [
@@ -31,9 +31,9 @@ const imageSrc = computed(() => {
3131
props.height ? `h_${props.height}` : '',
3232
]
3333
.filter((item) => item !== '')
34-
.join(',');
34+
.join(',')
3535
36-
return `${cloudinaryUrl}/${attributes}/v1/${props.src.replace(/^\/+/, '')}`;
36+
return `${imageStorageUrl}/${attributes}/v1/${props.src.replace(/^\/+/, '')}`
3737
})
3838
</script>
3939

src/developers/components/DeveloperLanding.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,4 @@ onMounted(() => {
113113
right: 48px;
114114
}
115115
}
116-
117-
118116
</style>

src/developers/components/DeveloperPage.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import partnerConfig from '../partnerConfig.js'
44
import { DeveloperProfile } from './type'
55
import { generateUTMUrl } from './utils'
66
import { VTIconChevronLeft, VTIconMapPin } from '@vue/theme'
7-
import CloudinaryImage from './CloudinaryImage.vue'
7+
import DeveloperImage from './DeveloperImage.vue'
88
import DeveloperCompensations from './DeveloperCompensations.vue'
99
import DeveloperProficiencies from './DeveloperProficiencies.vue'
1010
import DeveloperProfileDiagram from './DeveloperProfileDiagram.vue'
@@ -36,7 +36,7 @@ const hireUsLink = computed(() => generateUTMUrl(partnerConfig.hireUsButtonUrl,
3636

3737
<div class="developer-page__content">
3838
<div v-if="profileImage" class="developer-page__profile-image">
39-
<CloudinaryImage
39+
<DeveloperImage
4040
:src="profileImage"
4141
:alt="name"
4242
:width="592"

src/developers/components/DeveloperPageFooter.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { generateUTMUrl } from './utils'
77
88
const route = useRoute()
99
10-
const logoLink = computed(() => generateUTMUrl(partnerConfig.websiteUrl, route.path))
10+
const logoLink = computed(() => generateUTMUrl(partnerConfig.pageFooter.websiteVueLink || partnerConfig.websiteUrl, route.path))
1111
const hireUsLink = computed(() => generateUTMUrl(partnerConfig.hireUsButtonUrl, route.path))
1212
const websiteVuePageLink = computed(() => generateUTMUrl(partnerConfig.pageFooter.websiteVueLink, route.path))
1313
@@ -38,7 +38,9 @@ const { logo, partnerName } = partnerConfig
3838

3939
<div class="partner-footer__social-links">
4040
<a v-if="email" :href="`mailto:${email}`">{{ email }}</a>
41-
<p v-if="phone">{{ phone }}</p>
41+
<br />
42+
<a v-if="phone" :href="`tel:${phone}`">{{ phone }}</a>
43+
<br />
4244
<a v-if="websiteVuePageLink" :href="websiteVuePageLink" target="_blank">{{ websiteVueLabel }}</a>
4345
</div>
4446

src/developers/components/type.ts

Lines changed: 28 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,43 @@
11
export interface DeveloperExperienceDescription {
2-
isGrouped: boolean;
3-
content: string | string[];
2+
isGrouped: boolean
3+
content: string | string[]
44
}
5-
65
export interface DeveloperExperience {
7-
id: number;
8-
role: string;
9-
company: string;
10-
startDate: string;
11-
endDate: string;
12-
period: string;
13-
description: DeveloperExperienceDescription[];
14-
skills: string[];
6+
id: number
7+
role: string
8+
company: string
9+
startDate: string
10+
endDate: string
11+
period: string
12+
description: DeveloperExperienceDescription[]
13+
skills: string[]
1514
}
1615

1716
export interface DeveloperEducation {
18-
id: number;
19-
degree: string;
20-
school: string;
21-
startDate: string;
22-
endDate: string;
17+
id: number
18+
degree: string
19+
school: string
20+
startDate: string
21+
endDate: string
2322
}
2423

2524
export interface DeveloperCompensations {
26-
partTime: string;
27-
monthly: string;
25+
partTime: string
26+
monthly: string
2827
}
2928

3029
export interface DeveloperProfile {
31-
id: number;
32-
slug: string;
33-
name: string;
34-
alias: string;
35-
description: string[];
36-
proficiencies: string[];
37-
compensations: DeveloperCompensations;
38-
location: string;
39-
region: string;
40-
experiences?: DeveloperExperience[];
41-
education?: DeveloperEducation[];
30+
id: number
31+
slug: string
32+
name: string
33+
alias: string
34+
description: string[]
35+
proficiencies: string[]
36+
compensations: DeveloperCompensations
37+
location: string
38+
region: string
39+
experiences?: DeveloperExperience[]
40+
education?: DeveloperEducation[]
4241
}
4342

4443
export interface DeveloperProfiles extends Array<DeveloperProfile> {

src/developers/partnerConfig.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ const websiteLabel = 'proxify.io'
77
const websiteUrl = 'https://proxify.io/'
88
const applyUrl = 'https://career.proxify.io/apply'
99
const hireUrl = 'https://proxify.io/hire-vuejs'
10-
const cloudinaryUrl = 'https://res.cloudinary.com/proxify-io/image/upload'
10+
const vueArticleUrl = 'https://proxify.io/hire-vue-developers'
11+
const imageStorageUrl = 'https://res.cloudinary.com/proxify-io/image/upload'
1112

1213

1314
const partnerConfig = {
@@ -20,8 +21,8 @@ const partnerConfig = {
2021
websiteUrl: websiteUrl,
2122
hireUsButtonUrl: hireUrl,
2223

23-
// Cloudinary storage URL
24-
cloudinaryUrl: cloudinaryUrl,
24+
// Image storage URL
25+
imageStorageUrl: imageStorageUrl,
2526

2627
// Hero Section
2728
pageHeroBanner: {
@@ -48,8 +49,8 @@ const partnerConfig = {
4849
text: `This highly vetted developer is brought to you by Vue’s partner:`,
4950
email: 'vue@proxify.io',
5051
phone: '+44 20 4614 2667',
51-
websiteVueLink: hireUrl,
52-
websiteVueLabel: websiteLabel + '/vue'
52+
websiteVueLink: vueArticleUrl,
53+
websiteVueLabel: websiteLabel + '/hire-vue-developers'
5354
},
5455

5556
// Diagram sections

0 commit comments

Comments
 (0)