Move flake8 config to top level, add a separate CI action for linting

Author: eemeli

fluent.docs/setup.cfg renamed to .flake8

@@ -1,2 +1,3 @@
 [flake8]
+exclude=.tox
 max-line-length=120

.github/workflows/fluent.runtime.yml

@@ -43,24 +43,3 @@ jobs:
           python -m pip install .
       - run: ./runtests.py
         working-directory: ./fluent.runtime
-  lint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
-        with:
-          python-version: 3.9
-      - name: Install dependencies
-        working-directory: ./fluent.runtime
-        run: |
-          python -m pip install wheel
-          python -m pip install --upgrade pip
-          python -m pip install .
-          python -m pip install flake8==6 mypy==1 types-babel types-pytz
-      - name: Install latest fluent.syntax
-        working-directory: ./fluent.syntax
-        run: python -m pip install .
-      - run: python -m flake8
-        working-directory: ./fluent.runtime
-      - run: python -m mypy fluent/
-        working-directory: ./fluent.runtime

.github/workflows/fluent.syntax.yml

@@ -38,20 +38,3 @@ jobs:
           python -m pip install .
       - run: ./runtests.py
         working-directory: ./fluent.syntax
-  lint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
-        with:
-          python-version: 3.9
-      - name: Install dependencies
-        working-directory: ./fluent.syntax
-        run: |
-          python -m pip install --upgrade pip
-          python -m pip install .
-          python -m pip install flake8==6 mypy==1
-      - run: python -m flake8
-        working-directory: ./fluent.syntax
-      - run: python -m mypy fluent/
-        working-directory: ./fluent.syntax

.github/workflows/lint.yml

@@ -0,0 +1,20 @@
+name: lint
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: 3.9
+      - run: python -m pip install flake8==6 mypy==1 types-babel types-pytz
+      - run: python -m pip install ./fluent.syntax ./fluent.runtime
+      - run: python -m flake8
+      - run: python -m mypy fluent.syntax/fluent fluent.runtime/fluent

docs/conf.py

@@ -34,13 +34,16 @@
 # Add any paths that contain templates here, relative to this directory.
 templates_path = ['_templates']
 
+
 # Add src_dir/docs/_templates in a hook as we only have the src_dir then.
 def setup(app):
     app.connect('config-inited', add_templates)
 
+
 def add_templates(app, config):
     config.templates_path.insert(0, f'{app.srcdir}/_templates')
 
+
 # List of patterns, relative to source directory, that match files and
 # directories to ignore when looking for source files.
 # This pattern also affects html_static_path and html_extra_path.

fluent.pygments/setup.cfg

@@ -4,10 +4,6 @@ version=2.0
 [bdist_wheel]
 universal=1
 
-[flake8]
-exclude=.tox
-max-line-length=120
-
 [isort]
 line_length=120
 skip_glob=.tox

fluent.runtime/setup.cfg

@@ -4,10 +4,6 @@ version=0.4.0
 [bdist_wheel]
 universal=1
 
-[flake8]
-exclude=.tox
-max-line-length=120
-
 [isort]
 line_length=120
 skip_glob=.tox

fluent.syntax/setup.cfg

@@ -4,10 +4,6 @@ version=0.19.0
 [bdist_wheel]
 universal=1
 
-[flake8]
-exclude=.tox
-max-line-length=120
-
 [isort]
 line_length=120
 skip_glob=.tox

tools/fluentfmt.py

@@ -1,14 +1,14 @@
 #!/usr/bin/python
 
 import sys
-
-sys.path.append('./')
 import codecs
 from fluent.syntax import parse, serialize
 
+sys.path.append("./")
+
 
 def read_file(path):
-    with codecs.open(path, 'r', encoding='utf-8') as file:
+    with codecs.open(path, "r", encoding="utf-8") as file:
         text = file.read()
     return text
 
@@ -17,7 +17,8 @@ def pretty_print(fileType, data):
     ast = parse(data)
     print(serialize(ast))
 
+
 if __name__ == "__main__":
-    file_type = 'ftl'
+    file_type = "ftl"
     f = read_file(sys.argv[1])
     pretty_print(file_type, f)

tools/parse.py

@@ -1,12 +1,12 @@
 #!/usr/bin/python
 
 import sys
-
-sys.path.append('./')
 import codecs
 from fluent.syntax import parse
 import json
 
+sys.path.append('./')
+
 
 def read_file(path):
     with codecs.open(path, 'r', encoding='utf-8') as file:

tools/serialize.py

@@ -2,22 +2,23 @@
 
 import sys
 import json
-
-sys.path.append('./')
 import codecs
 from fluent.syntax import ast, serialize
 
+sys.path.append("./")
+
 
 def read_json(path):
-    with codecs.open(path, 'r', encoding='utf-8') as file:
+    with codecs.open(path, "r", encoding="utf-8") as file:
         return json.load(file)
 
 
 def pretty_print(fileType, data):
     resource = ast.from_json(data)
     print(serialize(resource))
 
+
 if __name__ == "__main__":
-    file_type = 'ftl'
+    file_type = "ftl"
     f = read_json(sys.argv[1])
     pretty_print(file_type, f)