runtime: Fix bugs found by static typing

Author: eemeli

fluent.runtime/fluent/runtime/fallback.py

@@ -107,7 +107,6 @@ def __init__(self, roots: Union[str, List[str]]):
         location on disk, or a list of strings.
         """
         self.roots = [roots] if isinstance(roots, str) else roots
-        self.Resource = FluentResource
 
     def resources(self, locale: str, resource_ids: List[str]) -> Generator[List['Resource'], None, None]:
         for root in self.roots:

fluent.runtime/fluent/runtime/resolver.py

@@ -229,6 +229,10 @@ def resolveEntryReference(
         ref_id = reference_to_id(ref)
         env.errors.append(unknown_reference_error_obj(ref_id))
         return FluentNone(f'{{{ref_id}}}')
+    except TypeError:
+        ref_id = reference_to_id(ref)
+        env.errors.append(FluentReferenceError(f"No pattern: {ref_id}"))
+        return FluentNone(ref_id)
 
 
 class MessageReference(FTL.MessageReference, BaseResolver):
@@ -298,6 +302,9 @@ def __call__(self, env: ResolverEnvironment) -> Union[str, FluentNone]:
                 break
 
         if found is None:
+            if default is None:
+                env.errors.append(FluentFormatError("No default"))
+                return FluentNone()
             found = default
         return found.value(env)
 

fluent.runtime/fluent/runtime/types.py

@@ -118,6 +118,8 @@ def format(self, locale: Locale) -> str:
             base_pattern = locale.currency_formats['standard']
             pattern = self._apply_options(base_pattern)
             return pattern.apply(selfnum, locale, currency=self.options.currency)  # type: ignore
+        # never happens
+        return '???'
 
     def _apply_options(self, pattern: NumberPattern) -> NumberPattern:
         # We are essentially trying to copy the
@@ -339,8 +341,6 @@ def _ensure_datetime_tzinfo(dt: datetime, tzinfo: Union[str, None] = None) -> da
         dt = dt.replace(tzinfo=pytz.UTC)
     if tzinfo is not None:
         dt = dt.astimezone(get_timezone(tzinfo))
-        if hasattr(tzinfo, 'normalize'):  # pytz
-            dt = tzinfo.normalize(datetime)
     return dt