fix unit tests

asm582 · openshift-merge-robot · commit d88044db2483 · 2023-09-09T22:21:28.000+02:00
diff --git a/pkg/controller/queuejob/queuejob_controller_ex.go b/pkg/controller/queuejob/queuejob_controller_ex.go
@@ -1706,7 +1706,7 @@ func (cc *XController) updateQueueJob(oldObj, newObj interface{}) {
 						latestAw, exists, err := cc.appwrapperInformer.Informer().GetStore().GetByKey(key)
 						if err == nil && exists {
 							// Enqueue the latest copy of the AW.
-							if (newQJ.Status.State != arbv1.AppWrapperStateCompleted || newQJ.Status.State != arbv1.AppWrapperStateFailed) && hasCompletionStatus {
+							if (newQJ.Status.State != arbv1.AppWrapperStateCompleted && newQJ.Status.State != arbv1.AppWrapperStateFailed) && hasCompletionStatus {
 								cc.UpdateQueueJobs(latestAw.(*arbv1.AppWrapper))
 								klog.V(2).Infof("[Informer-updateQJ] Finished requeing AW to determine completion status")
 							}

Original file line number	Diff line number	Diff line change
`@@ -1706,7 +1706,7 @@ func (cc *XController) updateQueueJob(oldObj, newObj interface{}) {`
`1706`	`1706`	`latestAw, exists, err := cc.appwrapperInformer.Informer().GetStore().GetByKey(key)`
`1707`	`1707`	`if err == nil && exists {`
`1708`	`1708`	`// Enqueue the latest copy of the AW.`
`1709`		`- if (newQJ.Status.State != arbv1.AppWrapperStateCompleted \|\| newQJ.Status.State != arbv1.AppWrapperStateFailed) && hasCompletionStatus {`
	`1709`	`+ if (newQJ.Status.State != arbv1.AppWrapperStateCompleted && newQJ.Status.State != arbv1.AppWrapperStateFailed) && hasCompletionStatus {`
`1710`	`1710`	`cc.UpdateQueueJobs(latestAw.(*arbv1.AppWrapper))`
`1711`	`1711`	`klog.V(2).Infof("[Informer-updateQJ] Finished requeing AW to determine completion status")`
`1712`	`1712`	`}`