Skip to content

Commit 86ae9e3

Browse files
committed
fix test
1 parent 25166ce commit 86ae9e3

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

pkg/controller/queuejob/queuejob_controller_ex.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ func (qjm *XController) getAggregatedAvailableResourcesPriority(unallocatedClust
908908
totalResource := qjm.addTotalSnapshotResourcesConsumedByAw(value.Status.TotalGPU, value.Status.TotalCPU, value.Status.TotalMemory)
909909
preemptable = preemptable.Add(totalResource)
910910
continue
911-
} else if value.Status.SystemPriority < targetpr || !value.Status.CanRun {
911+
} else if value.Status.SystemPriority < targetpr {
912912
// Dispatcher Mode: Ensure this job is part of the target cluster
913913
if qjm.isDispatcher {
914914
// Get the job key
@@ -940,23 +940,26 @@ func (qjm *XController) getAggregatedAvailableResourcesPriority(unallocatedClust
940940
klog.V(10).Infof("[getAggAvaiResPri] %s: Skipping adjustments for %s since priority %f is >= %f of requesting job: %s.", time.Now().String(),
941941
value.Name, value.Status.SystemPriority, targetpr, requestingJob.Name)
942942
continue
943-
} else if value.Status.CanRun && (targetpr < value.Status.SystemPriority) {
943+
} else if value.Status.CanRun {
944944
qjv := clusterstateapi.EmptyResource()
945945
for _, resctrl := range qjm.qjobResControls {
946-
qjv = resctrl.GetAggregatedResources(value)
946+
res := resctrl.GetAggregatedResources(value)
947+
qjv.Add(res)
947948
klog.V(10).Infof("[getAggAvaiResPri] Subtract all resources %+v in resctrlType=%T for job %s which can-run is set to: %v but state is still pending.", qjv, resctrl, value.Name, value.Status.CanRun)
948949
}
949950
for _, genericItem := range value.Spec.AggrResources.GenericItems {
950-
qjv, _ = genericresource.GetResources(&genericItem)
951+
res, _ := genericresource.GetResources(&genericItem)
952+
qjv.Add(res)
951953
klog.V(10).Infof("[getAggAvaiResPri] Subtract all resources %+v in resctrlType=%T for job %s which can-run is set to: %v but state is still pending.", qjv, genericItem, value.Name, value.Status.CanRun)
952954
}
953955

954956
totalResource := qjm.addTotalSnapshotResourcesConsumedByAw(value.Status.TotalGPU, value.Status.TotalCPU, value.Status.TotalMemory)
955-
pending, err = qjv.NonNegSub(totalResource)
957+
delta, err := qjv.NonNegSub(totalResource)
956958
if err != nil {
957-
klog.Errorf("[getAggAvaiResPri] Subtraction of resources failed, adding entire appwrapper resoources %v", qjv)
959+
klog.Errorf("[getAggAvaiResPri] Subtraction of resources failed, adding entire appwrapper resoources %v, %v", qjv, err)
958960
pending = qjv
959961
}
962+
pending = pending.Add(delta)
960963
continue
961964
} else {
962965
//Do nothing

0 commit comments

Comments
 (0)