Skip to content

Commit 09bdaca

Browse files
committed
fix review comments
1 parent 1d7cbee commit 09bdaca

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

.github/workflows/mcad-release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,6 @@ jobs:
3838
echo "Tag ${{ github.event.inputs.tag }} already exist. Exiting workflow."
3939
exit 1
4040
else
41-
gh release create ${{ github.event.inputs.tag }} --title "MCAD ${{ github.event.inputs.tag }} Release" --generate-notes
42-
fi
41+
gh release create ${{ github.event.inputs.tag }} --title "MCAD ${{ github.event.inputs.tag }} Release" --generate-notes --target ${{ github.ref }}
42+
fi
43+

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ifneq ($(strip $(GIT_BRANCH)),)
2323
RELEASE_VER:=${GIT_BRANCH}
2424
TAG:=release-${TAG}
2525
else
26-
RELEASE_VER:= $(shell curl -s https://pkg.go.dev/github.com/project-codeflare/multi-cluster-app-dispatcher | grep -o 'v[0-9]\+\.[0-9]\+\.[0-9]\+' | head -n 1)
26+
RELEASE_VER:= $(shell git describe --tags --abbrev=0)
2727
TAG:=${TAG}${GIT_BRANCH}
2828
# replace invalid characters that might exist in the branch name
2929
TAG:=$(shell echo ${TAG} | sed 's/[^a-zA-Z0-9]/-/g')

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Refer to [deployment instructions here](./doc/deploy/deployment.md) on how to de
1717

1818
## Release Process
1919

20-
1. Run the [mcad-release.yml](https://github.com/project-codeflare/actions/workflows/mcad-release.yml) action.
20+
1. Run the [mcad-release.yml](https://github.com/project-codeflare/actions/workflows/mcad-release.yml) action under `Actions` by entering the new release version in the `tag` input field.
2121

2222
2. Verify that [mcad-release.yml](https://github.com/project-codeflare/actions/workflows/mcad-release.yml) action passed successfully. This workflow will create GitHub release tag.
2323

deployment/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ CAT_CMD=$(if $(filter $(OS),Windows_NT),type,cat)
77
OPERATOR_VERSION_FILE=./OPERATOR_VERSION
88
OPERATOR_VER=v$(shell $(CAT_CMD) $(OPERATOR_VERSION_FILE))
99
OPERATOR_VER_NUM=$(shell $(CAT_CMD) $(OPERATOR_VERSION_FILE))
10-
CONTROLLER_VER=$(shell curl -s https://pkg.go.dev/github.com/project-codeflare/multi-cluster-app-dispatcher | grep -o 'v[0-9]\+\.[0-9]\+\.[0-9]\+' | head -n 1)
10+
CONTROLLER_VER=$(shell git describe --tags --abbrev=0)
1111

1212
check_delete_operator:
1313
@echo "****************************************************************************************************"

0 commit comments

Comments
 (0)