From 97a35d4455be5e80a5a1a450a37545310fa72a59 Mon Sep 17 00:00:00 2001 From: Bobbins228 Date: Tue, 20 Jun 2023 12:25:42 +0100 Subject: [PATCH 1/3] Added build args for codeflare-sdk in notebook image build --- custom-nb-image/Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/custom-nb-image/Dockerfile b/custom-nb-image/Dockerfile index 7200ed925..f9ce1a55c 100644 --- a/custom-nb-image/Dockerfile +++ b/custom-nb-image/Dockerfile @@ -13,7 +13,7 @@ # limitations under the License. FROM quay.io/opendatahub/notebooks:jupyter-minimal-ubi8-python-3.8-4c8f26e - +ARG SDK_VERSION=0.4.4 # Install: torch (v1.12), ray (v2.1.0) and others COPY requirements.txt requirements.txt @@ -23,7 +23,7 @@ RUN pip install -r requirements.txt RUN pip uninstall pickle5 -y # Install codeflare-sdk and other libraries -RUN pip install codeflare-sdk==0.4.4 \ +RUN pip install codeflare-sdk==${SDK_VERSION} \ datasets==2.6.1 \ transformers==4.23.1 \ evaluate==0.3.0 From adf0236efcceda6296df8e8ebb5c54ef62e9da6d Mon Sep 17 00:00:00 2001 From: Bobbins228 Date: Tue, 20 Jun 2023 15:24:49 +0100 Subject: [PATCH 2/3] Moved arg location in Dockerfile --- custom-nb-image/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/custom-nb-image/Dockerfile b/custom-nb-image/Dockerfile index f9ce1a55c..503de1fad 100644 --- a/custom-nb-image/Dockerfile +++ b/custom-nb-image/Dockerfile @@ -13,7 +13,6 @@ # limitations under the License. FROM quay.io/opendatahub/notebooks:jupyter-minimal-ubi8-python-3.8-4c8f26e -ARG SDK_VERSION=0.4.4 # Install: torch (v1.12), ray (v2.1.0) and others COPY requirements.txt requirements.txt @@ -23,6 +22,7 @@ RUN pip install -r requirements.txt RUN pip uninstall pickle5 -y # Install codeflare-sdk and other libraries +ARG SDK_VERSION=0.4.4 RUN pip install codeflare-sdk==${SDK_VERSION} \ datasets==2.6.1 \ transformers==4.23.1 \ From 95f503b8637de42746f883b1a8029fab3b885b30 Mon Sep 17 00:00:00 2001 From: Bobbins228 Date: Tue, 20 Jun 2023 15:31:10 +0100 Subject: [PATCH 3/3] Changed default SDK version to 0.* --- custom-nb-image/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/custom-nb-image/Dockerfile b/custom-nb-image/Dockerfile index 503de1fad..e5393f8b9 100644 --- a/custom-nb-image/Dockerfile +++ b/custom-nb-image/Dockerfile @@ -22,7 +22,7 @@ RUN pip install -r requirements.txt RUN pip uninstall pickle5 -y # Install codeflare-sdk and other libraries -ARG SDK_VERSION=0.4.4 +ARG SDK_VERSION=0.* RUN pip install codeflare-sdk==${SDK_VERSION} \ datasets==2.6.1 \ transformers==4.23.1 \