From 98b2dc304c6cd0ee19461376b541b33e582107fb Mon Sep 17 00:00:00 2001 From: ted chang Date: Wed, 31 May 2023 15:33:26 -0700 Subject: [PATCH 1/4] Update testing instruction --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index ae35b852e..b0cee3c83 100644 --- a/README.md +++ b/README.md @@ -29,6 +29,8 @@ We use pre-commit to make sure the code is consistently formatted. To make sure ### Testing +> Some tests, i.e. test_ray_details,test_cluster_status,and test_wait_ready require an Openshift cluster with [Codeflare Stack](https://github.com/opendatahub-io/distributed-workloads/blob/main/Quick-Start.md#quick-start-guide-for-distributed-workflows-with-the-codeflare-stack) installed. +- To install codeflare-sdk in editable mode, run `pip install -e .` from the repo root. - To run the unit tests, run `pytest -v tests/unit_test.py` - Any new test functions/scripts can be added into the `tests` folder - NOTE: Functional tests coming soon, will live in `tests/func_test.py` From 6d79b6f62d88a4fac7b7b5730a087fb4daa1289a Mon Sep 17 00:00:00 2001 From: ted chang Date: Wed, 31 May 2023 16:06:19 -0700 Subject: [PATCH 2/4] Add commit suggestion 1 Co-authored-by: Anish Asthana --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b0cee3c83..40c061581 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,7 @@ We use pre-commit to make sure the code is consistently formatted. To make sure ### Testing -> Some tests, i.e. test_ray_details,test_cluster_status,and test_wait_ready require an Openshift cluster with [Codeflare Stack](https://github.com/opendatahub-io/distributed-workloads/blob/main/Quick-Start.md#quick-start-guide-for-distributed-workflows-with-the-codeflare-stack) installed. +> Some tests, i.e. test_ray_details, test_cluster_status, and test_wait_ready require an OpenShift cluster with the [Codeflare Stack](https://github.com/opendatahub-io/distributed-workloads/blob/main/Quick-Start.md#quick-start-guide-for-distributed-workflows-with-the-codeflare-stack) installed. - To install codeflare-sdk in editable mode, run `pip install -e .` from the repo root. - To run the unit tests, run `pytest -v tests/unit_test.py` - Any new test functions/scripts can be added into the `tests` folder From 10beb541e2b6cf273ba121a3fefd4f53dbbc9760 Mon Sep 17 00:00:00 2001 From: ted chang Date: Thu, 1 Jun 2023 09:03:04 -0700 Subject: [PATCH 3/4] rename OWNERS file --- OWNERS.md => OWNERS | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename OWNERS.md => OWNERS (100%) diff --git a/OWNERS.md b/OWNERS similarity index 100% rename from OWNERS.md rename to OWNERS From 773f3d0c0272df331549e1f328cec8ed043fc700 Mon Sep 17 00:00:00 2001 From: ted chang Date: Wed, 7 Jun 2023 15:09:59 -0700 Subject: [PATCH 4/4] Remove the false warning message --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 40c061581..6b33278a4 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,6 @@ We use pre-commit to make sure the code is consistently formatted. To make sure ### Testing -> Some tests, i.e. test_ray_details, test_cluster_status, and test_wait_ready require an OpenShift cluster with the [Codeflare Stack](https://github.com/opendatahub-io/distributed-workloads/blob/main/Quick-Start.md#quick-start-guide-for-distributed-workflows-with-the-codeflare-stack) installed. - To install codeflare-sdk in editable mode, run `pip install -e .` from the repo root. - To run the unit tests, run `pytest -v tests/unit_test.py` - Any new test functions/scripts can be added into the `tests` folder