refactor: refactor update_image_pull_secrets

Author: VanillaSpoon

src/codeflare_sdk/utils/generate_yaml.py

@@ -142,11 +142,10 @@ def update_image(spec, image):
 
 
 def update_image_pull_secrets(spec, image_pull_secrets):
-    if image_pull_secrets:
-        if "imagePullSecrets" not in spec:
-            spec["imagePullSecrets"] = []
-        for image_pull_secret in image_pull_secrets:
-            spec["imagePullSecrets"].append({"name": image_pull_secret})
+    template_secrets = spec.get("imagePullSecrets", [])
+    spec["imagePullSecrets"] = template_secrets + [
+        {"name": x} for x in image_pull_secrets
+    ]
 
 
 def update_env(spec, env):

tests/test-case-cmd.yaml

@@ -96,6 +96,7 @@ spec:
                       cpu: 2
                       memory: 8G
                       nvidia.com/gpu: 0
+                imagePullSecrets: []
           rayVersion: 2.1.0
           workerGroupSpecs:
           - groupName: small-group-unit-cmd-cluster
@@ -144,6 +145,7 @@ spec:
                       cpu: 1
                       memory: 2G
                       nvidia.com/gpu: 1
+                imagePullSecrets: []
                 initContainers:
                 - command:
                   - sh