Skip to content

Commit e14e72c

Browse files
committed
review comments
1 parent b710677 commit e14e72c

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/e2e_tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
- name: Set Go
7070
uses: actions/setup-go@v5
7171
with:
72-
go-version: v1.21
72+
go-version-file: './go.mod'
7373

7474
- name: Set up gotestfmt
7575
uses: gotesttools/gotestfmt-action@v2

src/codeflare_sdk/cluster/cluster.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -900,10 +900,7 @@ def _get_app_wrappers(
900900

901901
for item in aws["items"]:
902902
app_wrapper = _map_to_app_wrapper(item)
903-
if filter:
904-
if app_wrapper.status in filter:
905-
list_of_app_wrappers.append(app_wrapper)
906-
else:
903+
if not filter or app_wrapper.status in filter:
907904
list_of_app_wrappers.append(app_wrapper)
908905
return list_of_app_wrappers
909906

@@ -988,11 +985,13 @@ def _map_to_app_wrapper(aw) -> AppWrapper:
988985
if "status" in aw:
989986
return AppWrapper(
990987
name=aw["metadata"]["name"],
991-
status=AppWrapperStatus(aw["status"].get("phase", "suspended").lower()),
988+
status=AppWrapperStatus(
989+
aw["status"].get("phase", AppWrapperStatus.SUSPENDED.value).lower()
990+
),
992991
)
993992
return AppWrapper(
994993
name=aw["metadata"]["name"],
995-
status=AppWrapperStatus("suspended"),
994+
status=AppWrapperStatus.SUSPENDED,
996995
)
997996

998997

0 commit comments

Comments
 (0)