Skip to content

Commit 62be50e

Browse files
Updated ray v1alpha1 to v1
1 parent e7d5255 commit 62be50e

File tree

13 files changed

+26
-26
lines changed

13 files changed

+26
-26
lines changed

demo-notebooks/guided-demos/notebook-ex-outputs/gptfttest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
memory: 8G
3030
nvidia.com/gpu: 1
3131
generictemplate:
32-
apiVersion: ray.io/v1alpha1
32+
apiVersion: ray.io/v1
3333
kind: RayCluster
3434
metadata:
3535
labels:

demo-notebooks/guided-demos/notebook-ex-outputs/instascaletest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
memory: 8G
3030
nvidia.com/gpu: 1
3131
generictemplate:
32-
apiVersion: ray.io/v1alpha1
32+
apiVersion: ray.io/v1
3333
kind: RayCluster
3434
metadata:
3535
labels:

demo-notebooks/guided-demos/notebook-ex-outputs/interactivetest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
memory: 8G
3030
nvidia.com/gpu: 1
3131
generictemplate:
32-
apiVersion: ray.io/v1alpha1
32+
apiVersion: ray.io/v1
3333
kind: RayCluster
3434
metadata:
3535
labels:

demo-notebooks/guided-demos/notebook-ex-outputs/jobtest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ spec:
2727
memory: 4G
2828
nvidia.com/gpu: 0
2929
generictemplate:
30-
apiVersion: ray.io/v1alpha1
30+
apiVersion: ray.io/v1
3131
kind: RayCluster
3232
metadata:
3333
labels:

demo-notebooks/guided-demos/notebook-ex-outputs/raytest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ spec:
2727
memory: 4G
2828
nvidia.com/gpu: 0
2929
generictemplate:
30-
apiVersion: ray.io/v1alpha1
30+
apiVersion: ray.io/v1
3131
kind: RayCluster
3232
metadata:
3333
labels:

src/codeflare_sdk/cluster/cluster.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ def _component_resources_up(
557557
if resource["kind"] == "RayCluster":
558558
api_instance.create_namespaced_custom_object(
559559
group="ray.io",
560-
version="v1alpha1",
560+
version="v1",
561561
namespace=namespace,
562562
plural="rayclusters",
563563
body=resource,
@@ -594,7 +594,7 @@ def _component_resources_down(
594594
if resource["kind"] == "RayCluster":
595595
api_instance.delete_namespaced_custom_object(
596596
group="ray.io",
597-
version="v1alpha1",
597+
version="v1",
598598
namespace=namespace,
599599
plural="rayclusters",
600600
name=self.app_wrapper_name,
@@ -681,7 +681,7 @@ def get_cluster(cluster_name: str, namespace: str = "default"):
681681
api_instance = client.CustomObjectsApi(api_config_handler())
682682
rcs = api_instance.list_namespaced_custom_object(
683683
group="ray.io",
684-
version="v1alpha1",
684+
version="v1",
685685
namespace=namespace,
686686
plural="rayclusters",
687687
)
@@ -838,7 +838,7 @@ def _ray_cluster_status(name, namespace="default") -> Optional[RayCluster]:
838838
api_instance = client.CustomObjectsApi(api_config_handler())
839839
rcs = api_instance.list_namespaced_custom_object(
840840
group="ray.io",
841-
version="v1alpha1",
841+
version="v1",
842842
namespace=namespace,
843843
plural="rayclusters",
844844
)
@@ -858,7 +858,7 @@ def _get_ray_clusters(namespace="default") -> List[RayCluster]:
858858
api_instance = client.CustomObjectsApi(api_config_handler())
859859
rcs = api_instance.list_namespaced_custom_object(
860860
group="ray.io",
861-
version="v1alpha1",
861+
version="v1",
862862
namespace=namespace,
863863
plural="rayclusters",
864864
)

src/codeflare_sdk/cluster/model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class RayClusterStatus(Enum):
2727
Defines the possible reportable states of a Ray cluster.
2828
"""
2929

30-
# https://github.com/ray-project/kuberay/blob/master/ray-operator/apis/ray/v1alpha1/raycluster_types.go#L95
30+
# https://github.com/ray-project/kuberay/blob/master/ray-operator/apis/ray/v1/raycluster_types.go#L112-L117
3131
READY = "ready"
3232
UNHEALTHY = "unhealthy"
3333
FAILED = "failed"

src/codeflare_sdk/templates/base-template.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ spec:
3737
# The resource requests and limits in this config are too small for production!
3838
# For an example with more realistic resource configuration, see
3939
# ray-cluster.autoscaler.large.yaml.
40-
apiVersion: ray.io/v1alpha1
40+
apiVersion: ray.io/v1
4141
kind: RayCluster
4242
metadata:
4343
labels:

tests/test-case-bad.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
memory: 5G
3030
nvidia.com/gpu: 7
3131
generictemplate:
32-
apiVersion: ray.io/v1alpha1
32+
apiVersion: ray.io/v1
3333
kind: RayCluster
3434
metadata:
3535
labels:

tests/test-case-no-mcad.yamls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
apiVersion: ray.io/v1alpha1
2+
apiVersion: ray.io/v1
33
kind: RayCluster
44
metadata:
55
labels:

tests/test-case-prio.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
memory: 5G
3030
nvidia.com/gpu: 7
3131
generictemplate:
32-
apiVersion: ray.io/v1alpha1
32+
apiVersion: ray.io/v1
3333
kind: RayCluster
3434
metadata:
3535
labels:

tests/test-case.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ spec:
2828
memory: 5G
2929
nvidia.com/gpu: 7
3030
generictemplate:
31-
apiVersion: ray.io/v1alpha1
31+
apiVersion: ray.io/v1
3232
kind: RayCluster
3333
metadata:
3434
labels:

tests/unit_test.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ def arg_check_apply_effect(group, version, namespace, plural, body, *args):
397397
assert body == aw
398398
elif plural == "rayclusters":
399399
assert group == "ray.io"
400-
assert version == "v1alpha1"
400+
assert version == "v1"
401401
with open(f"{aw_dir}unit-test-cluster-ray.yaml") as f:
402402
yamls = yaml.load_all(f, Loader=yaml.FullLoader)
403403
for resource in yamls:
@@ -432,7 +432,7 @@ def arg_check_del_effect(group, version, namespace, plural, name, *args):
432432
assert name == "unit-test-cluster"
433433
elif plural == "rayclusters":
434434
assert group == "ray.io"
435-
assert version == "v1alpha1"
435+
assert version == "v1"
436436
assert name == "unit-test-cluster-ray"
437437
elif plural == "ingresses":
438438
assert group == "networking.k8s.io"
@@ -533,7 +533,7 @@ def test_aw_status(mocker):
533533

534534
def rc_status_fields(group, version, namespace, plural, *args):
535535
assert group == "ray.io"
536-
assert version == "v1alpha1"
536+
assert version == "v1"
537537
assert namespace == "test-ns"
538538
assert plural == "rayclusters"
539539
assert args == tuple()
@@ -913,7 +913,7 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
913913
api_obj = {
914914
"items": [
915915
{
916-
"apiVersion": "ray.io/v1alpha1",
916+
"apiVersion": "ray.io/v1",
917917
"kind": "RayCluster",
918918
"metadata": {
919919
"creationTimestamp": "2023-02-22T16:26:07Z",
@@ -926,7 +926,7 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
926926
},
927927
"managedFields": [
928928
{
929-
"apiVersion": "ray.io/v1alpha1",
929+
"apiVersion": "ray.io/v1",
930930
"fieldsType": "FieldsV1",
931931
"fieldsV1": {
932932
"f:metadata": {
@@ -986,7 +986,7 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
986986
"time": "2023-02-22T16:26:07Z",
987987
},
988988
{
989-
"apiVersion": "ray.io/v1alpha1",
989+
"apiVersion": "ray.io/v1",
990990
"fieldsType": "FieldsV1",
991991
"fieldsV1": {
992992
"f:status": {
@@ -1186,7 +1186,7 @@ def get_aw_obj(group, version, namespace, plural):
11861186
"kind": "AppWrapper",
11871187
"metadata": {
11881188
"annotations": {
1189-
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest1","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1alpha1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest1","controller-tools.k8s.io":"1.0"},"name":"quicktest1","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"rayVersion":"1.12.0","workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
1189+
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest1","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest1","controller-tools.k8s.io":"1.0"},"name":"quicktest1","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"rayVersion":"1.12.0","workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
11901190
},
11911191
"creationTimestamp": "2023-02-22T16:26:07Z",
11921192
"generation": 4,
@@ -1280,7 +1280,7 @@ def get_aw_obj(group, version, namespace, plural):
12801280
},
12811281
],
12821282
"generictemplate": {
1283-
"apiVersion": "ray.io/v1alpha1",
1283+
"apiVersion": "ray.io/v1",
12841284
"kind": "RayCluster",
12851285
"metadata": {
12861286
"labels": {
@@ -1514,7 +1514,7 @@ def get_aw_obj(group, version, namespace, plural):
15141514
"kind": "AppWrapper",
15151515
"metadata": {
15161516
"annotations": {
1517-
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest2","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1alpha1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest2","controller-tools.k8s.io":"1.0"},"name":"quicktest2","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"rayVersion":"1.12.0","workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
1517+
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest2","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest2","controller-tools.k8s.io":"1.0"},"name":"quicktest2","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"rayVersion":"1.12.0","workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
15181518
},
15191519
"creationTimestamp": "2023-02-22T16:26:07Z",
15201520
"generation": 4,
@@ -1608,7 +1608,7 @@ def get_aw_obj(group, version, namespace, plural):
16081608
},
16091609
],
16101610
"generictemplate": {
1611-
"apiVersion": "ray.io/v1alpha1",
1611+
"apiVersion": "ray.io/v1",
16121612
"kind": "RayCluster",
16131613
"metadata": {
16141614
"labels": {

0 commit comments

Comments
 (0)