Skip to content

Commit 5e1e1fa

Browse files
sutaakarabhijeet-dhumal
authored andcommitted
add provision to delete kueue resources created during test
1 parent a057ac1 commit 5e1e1fa

7 files changed

+35
-1
lines changed

demo-notebooks/guided-demos/1_cluster_job_client.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@
179179
"outputs": [],
180180
"source": [
181181
"# Delete a job\n",
182-
"# Can run client.cancel_job(submission_id) first if job is still running\n",
182+
"# Can run client.stop_job(submission_id) first if job is still running\n",
183183
"client.delete_job(submission_id)"
184184
]
185185
},

tests/e2e/local_interactive_sdk_kind_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_local_interactives(self):
2425
self.setup_method()

tests/e2e/local_interactive_sdk_oauth_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_local_interactives(self):
2425
self.setup_method()

tests/e2e/mnist_raycluster_sdk_kind_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_mnist_ray_cluster_sdk_kind(self):
2425
self.setup_method()

tests/e2e/mnist_raycluster_sdk_oauth_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_mnist_ray_cluster_sdk_auth(self):
2425
self.setup_method()

tests/e2e/support.py

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,3 +163,31 @@ def create_kueue_resources(
163163
body=local_queue_json,
164164
)
165165
print(f"'{local_queue}' created in namespace '{self.namespace}'")
166+
167+
168+
def delete_kueue_resources(
169+
self, cluster_queue="cluster-queue-mnist", flavor="default-flavor-mnist"
170+
):
171+
# Delete if given resource-flavor exists
172+
try:
173+
self.custom_api.delete_cluster_custom_object(
174+
group="kueue.x-k8s.io",
175+
plural="resourceflavors",
176+
version="v1beta1",
177+
name=flavor,
178+
)
179+
print(f"'{flavor}' resource-flavor deleted")
180+
except Exception as e:
181+
print(f"Error deleting resource-flavor '{flavor}' : {e}")
182+
183+
# Delete if given cluster-queue exists
184+
try:
185+
self.custom_api.delete_cluster_custom_object(
186+
group="kueue.x-k8s.io",
187+
plural="clusterqueues",
188+
version="v1beta1",
189+
name=cluster_queue,
190+
)
191+
print(f"'{cluster_queue}' cluster-queue deleted")
192+
except Exception as e:
193+
print(f"Error deleting cluster-queue '{cluster_queue}' : {e}")

tests/upgrade/raycluster_sdk_upgrade_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ def setup_method(self):
2121
create_kueue_resources(self)
2222
except Exception as e:
2323
delete_namespace(self)
24+
delete_kueue_resources(self)
2425
return _kube_api_error_handling(e)
2526

2627
def test_mnist_ray_cluster_sdk_auth(self):
@@ -69,6 +70,7 @@ def run_mnist_raycluster_sdk_oauth(self):
6970
except Exception as e:
7071
print(f"An unexpected error occurred. Error: ", e)
7172
delete_namespace(self)
73+
delete_kueue_resources(self)
7274
assert False, "Cluster is not ready!"
7375

7476

0 commit comments

Comments
 (0)