Remove openshift_oauth configuration

Author: ChristianZaccaria

src/codeflare_sdk/cluster/cluster.py

@@ -97,7 +97,7 @@ def job_client(self):
             self._job_submission_client = JobSubmissionClient(
                 self.cluster_dashboard_uri(),
                 headers=self._client_headers,
-                verify=self._client_verify_tls,
+                verify=False,
             )
         else:
             self._job_submission_client = JobSubmissionClient(
@@ -354,7 +354,7 @@ def is_dashboard_ready(self) -> bool:
                 self.cluster_dashboard_uri(),
                 headers=self._client_headers,
                 timeout=5,
-                verify=self._client_verify_tls,
+                verify=False,
             )
         except requests.exceptions.SSLError:  # pragma no cover
             # SSL exception occurs when oauth ingress has been created but cluster is not up

src/codeflare_sdk/templates/base-template.yaml

@@ -42,7 +42,6 @@ spec:
         metadata:
           annotations:
             sdk.codeflare.dev/local_interactive: "False"
-            codeflare.dev/oauth: 'False'
           labels:
             workload.codeflare.dev/appwrapper: "aw-kuberay"
             controller-tools.k8s.io: "1.0"

src/codeflare_sdk/utils/generate_yaml.py

@@ -219,13 +219,12 @@ def update_rayclient_ingress(
     spec["rules"][0]["host"] = f"rayclient-{cluster_name}-{namespace}.{ingress_domain}"
 
 
-def update_names(yaml, item, appwrapper_name, cluster_name, namespace, openshift_oauth):
+def update_names(yaml, item, appwrapper_name, cluster_name, namespace):
     metadata = yaml.get("metadata")
     metadata["name"] = appwrapper_name
     metadata["namespace"] = namespace
     lower_meta = item.get("generictemplate", {}).get("metadata")
     lower_meta["labels"]["workload.codeflare.dev/appwrapper"] = appwrapper_name
-    lower_meta["annotations"]["codeflare.dev/oauth"] = f"{openshift_oauth}"
     lower_meta["name"] = cluster_name
     lower_meta["namespace"] = namespace
     lower_spec = item.get("generictemplate", {}).get("spec")

tests/test-case-no-mcad.yamls

@@ -3,7 +3,6 @@ apiVersion: ray.io/v1
 kind: RayCluster
 metadata:
   annotations:
-    codeflare.dev/oauth: 'False'
     sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
     sdk.codeflare.dev/local_interactive: 'False'
   labels:

tests/test-case-prio.yaml

@@ -33,7 +33,6 @@ spec:
         kind: RayCluster
         metadata:
           annotations:
-            codeflare.dev/oauth: 'False'
             sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
             sdk.codeflare.dev/local_interactive: 'False'
           labels:

tests/test-case.yaml

@@ -32,7 +32,6 @@ spec:
         kind: RayCluster
         metadata:
           annotations:
-            codeflare.dev/oauth: 'False'
             sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
             sdk.codeflare.dev/local_interactive: 'False'
           labels:

tests/test-default-appwrapper.yaml

@@ -32,7 +32,6 @@ spec:
           annotations:
             sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
             sdk.codeflare.dev/local_interactive: 'False'
-            codeflare.dev/oauth: 'False'
           labels:
             controller-tools.k8s.io: '1.0'
             workload.codeflare.dev/appwrapper: unit-test-default-cluster