Skip to content

Commit 35eaa6d

Browse files
jiripetrlikanishasthana
authored andcommitted
Update README.md with release steps
1 parent 1fe04c3 commit 35eaa6d

File tree

3 files changed

+33
-0
lines changed

3 files changed

+33
-0
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ __pycache__/
44
.coverage
55
Pipfile
66
Pipfile.lock
7+
poetry.lock

README.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,29 @@ We use pre-commit to make sure the code is consistently formatted. To make sure
4747
### Package Build
4848

4949
To build the python package: `$ poetry build`
50+
51+
## Release Instructions
52+
53+
The following instructions apply when doing release manually.
54+
55+
* Check and update the version in "pyproject.toml" file.
56+
* Generate new documentation.
57+
`pdoc --html -o docs src/codeflare_sdk && pushd docs && rm -rf cluster job utils && mv codeflare_sdk/* . && rm -rf codeflare_sdk && popd` (it is possible to install **pdoc** using the following command `poetry install --with docs`)
58+
* Commit all the changes to the repository.
59+
* Create Github release (https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#creating-a-release).
60+
* Build the Python package. `poetry build`
61+
* If not present already, add the API token to Poetry.
62+
`poetry config pypi-token.pypi API_TOKEN`
63+
* Publish the Python package. `poetry publish`
64+
* Check and update the version in "custom-nb-image/VERSION" file.
65+
* Update the codeflare-sdk version in "custom-nb-image/Dockerfile".
66+
* Commit all the changes to the repository.
67+
* The Github "Image" workflow should take care about the building and publishing of the new image. If not you can
68+
use the following instructions to build and publish image manually.
69+
* Change directory to custom-nb-image. `cd custom-nb-image`
70+
* Get tag `export tag=$(cat VERSION)`
71+
* Build the Docker image. `docker build -t quay.io/project-codeflare/notebook:${tag} .`
72+
* Tag the image as latest. `docker tag quay.io/project-codeflare/notebook:${tag} quay.io/project-codeflare/notebook:latest`
73+
* Login to quay.io. `docker login quay.io`
74+
* Push the image. `docker push quay.io/project-codeflare/notebook:${tag}`
75+
* Push the image. `docker push quay.io/project-codeflare/notebook:latest`

pyproject.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,9 @@ rich = "^12.5"
2626
ray = {version = "2.1.0", extras = ["default"]}
2727
kubernetes = "26.1.0"
2828
codeflare-torchx = "0.6.0.dev0"
29+
30+
[tool.poetry.group.docs]
31+
optional = true
32+
33+
[tool.poetry.group.docs.dependencies]
34+
pdoc3 = "0.10.0"

0 commit comments

Comments
 (0)