Skip to content

Commit 2514bc9

Browse files
Remove creation of OAuth resources/logic and add annotation
1 parent 101ade2 commit 2514bc9

File tree

6 files changed

+7
-1
lines changed

6 files changed

+7
-1
lines changed

src/codeflare_sdk/templates/base-template.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ spec:
4242
metadata:
4343
annotations:
4444
sdk.codeflare.dev/local_interactive: "False"
45+
codeflare.dev/oauth: 'False'
4546
labels:
4647
workload.codeflare.dev/appwrapper: "aw-kuberay"
4748
controller-tools.k8s.io: "1.0"

src/codeflare_sdk/utils/generate_yaml.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,12 +219,13 @@ def update_rayclient_ingress(
219219
spec["rules"][0]["host"] = f"rayclient-{cluster_name}-{namespace}.{ingress_domain}"
220220

221221

222-
def update_names(yaml, item, appwrapper_name, cluster_name, namespace):
222+
def update_names(yaml, item, appwrapper_name, cluster_name, namespace, openshift_oauth):
223223
metadata = yaml.get("metadata")
224224
metadata["name"] = appwrapper_name
225225
metadata["namespace"] = namespace
226226
lower_meta = item.get("generictemplate", {}).get("metadata")
227227
lower_meta["labels"]["workload.codeflare.dev/appwrapper"] = appwrapper_name
228+
lower_meta["annotations"]["codeflare.dev/oauth"] = f"{openshift_oauth}"
228229
lower_meta["name"] = cluster_name
229230
lower_meta["namespace"] = namespace
230231
lower_spec = item.get("generictemplate", {}).get("spec")

tests/test-case-no-mcad.yamls

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apiVersion: ray.io/v1
33
kind: RayCluster
44
metadata:
55
annotations:
6+
codeflare.dev/oauth: 'False'
67
sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
78
sdk.codeflare.dev/local_interactive: 'False'
89
labels:

tests/test-case-prio.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ spec:
3333
kind: RayCluster
3434
metadata:
3535
annotations:
36+
codeflare.dev/oauth: 'False'
3637
sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
3738
sdk.codeflare.dev/local_interactive: 'False'
3839
labels:

tests/test-case.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ spec:
3232
kind: RayCluster
3333
metadata:
3434
annotations:
35+
codeflare.dev/oauth: 'False'
3536
sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
3637
sdk.codeflare.dev/local_interactive: 'False'
3738
labels:

tests/test-default-appwrapper.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ spec:
3232
annotations:
3333
sdk.codeflare.dev/ingress_domain: apps.cluster.awsroute.org
3434
sdk.codeflare.dev/local_interactive: 'False'
35+
codeflare.dev/oauth: 'False'
3536
labels:
3637
controller-tools.k8s.io: '1.0'
3738
workload.codeflare.dev/appwrapper: unit-test-default-cluster

0 commit comments

Comments
 (0)