Skip to content

Commit 1172cfb

Browse files
add provision to delete kueue resources created during test execution
1 parent c0f7d7f commit 1172cfb

6 files changed

+40
-7
lines changed

tests/e2e/local_interactive_sdk_kind_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_local_interactives(self):
2425
self.setup_method()
2526
create_namespace(self)
2627
create_kueue_resources(self)
2728
self.run_local_interactives()
28-
self.teardown_method()
2929

3030
def run_local_interactives(self):
3131
ray_image = get_ray_image()

tests/e2e/local_interactive_sdk_oauth_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_local_interactives(self):
2425
self.setup_method()
2526
create_namespace(self)
2627
create_kueue_resources(self)
2728
self.run_local_interactives()
28-
self.teardown_method()
2929

3030
def run_local_interactives(self):
3131
ray_image = get_ray_image()

tests/e2e/mnist_raycluster_sdk_kind_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_mnist_ray_cluster_sdk_kind(self):
2425
self.setup_method()
2526
create_namespace(self)
2627
create_kueue_resources(self)
2728
self.run_mnist_raycluster_sdk_kind()
28-
self.teardown_method()
2929

3030
def run_mnist_raycluster_sdk_kind(self):
3131
ray_image = get_ray_image()

tests/e2e/mnist_raycluster_sdk_oauth_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ def setup_method(self):
1919

2020
def teardown_method(self):
2121
delete_namespace(self)
22+
delete_kueue_resources(self)
2223

2324
def test_mnist_ray_cluster_sdk_auth(self):
2425
self.setup_method()
2526
create_namespace(self)
2627
create_kueue_resources(self)
2728
self.run_mnist_raycluster_sdk_oauth()
28-
self.teardown_method()
2929

3030
def run_mnist_raycluster_sdk_oauth(self):
3131
ray_image = get_ray_image()

tests/e2e/support.py

Lines changed: 35 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,17 @@ def run_oc_command(args):
5959
return None
6060

6161

62+
# Global variables for kueue resources
63+
cluster_queue = "cluster-queue-mnist"
64+
flavor = "default-flavor-mnist"
65+
local_queue = "local-queue-mnist"
66+
67+
6268
def create_kueue_resources(
6369
self,
64-
cluster_queue="cluster-queue-mnist",
65-
flavor="default-flavor-mnist",
66-
local_queue="local-queue-mnist",
70+
cluster_queue=cluster_queue,
71+
flavor=flavor,
72+
local_queue=local_queue,
6773
):
6874
print("creating Kueue resources ...")
6975
resource_flavor_json = {
@@ -163,3 +169,29 @@ def create_kueue_resources(
163169
body=local_queue_json,
164170
)
165171
print(f"'{local_queue}' created in namespace '{self.namespace}'")
172+
173+
174+
def delete_kueue_resources(self, cluster_queue=cluster_queue, flavor=flavor):
175+
# Delete if given cluster-queue exists
176+
try:
177+
self.custom_api.delete_cluster_custom_object(
178+
group="kueue.x-k8s.io",
179+
plural="clusterqueues",
180+
version="v1beta1",
181+
name=cluster_queue,
182+
)
183+
print(f"\n'{cluster_queue}' cluster-queue deleted")
184+
except Exception as e:
185+
print(f"\nError deleting cluster-queue '{cluster_queue}' : {e}")
186+
187+
# Delete if given resource-flavor exists
188+
try:
189+
self.custom_api.delete_cluster_custom_object(
190+
group="kueue.x-k8s.io",
191+
plural="resourceflavors",
192+
version="v1beta1",
193+
name=flavor,
194+
)
195+
print(f"'{flavor}' resource-flavor deleted")
196+
except Exception as e:
197+
print(f"\nError deleting resource-flavor '{flavor}' : {e}")

tests/upgrade/raycluster_sdk_upgrade_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ def setup_method(self):
2121
create_kueue_resources(self)
2222
except Exception as e:
2323
delete_namespace(self)
24+
delete_kueue_resources(self)
2425
return _kube_api_error_handling(e)
2526

2627
def test_mnist_ray_cluster_sdk_auth(self):

0 commit comments

Comments
 (0)