Skip to content

Commit 0e294eb

Browse files
committed
cleanup from botched whitespace merge in rebase
1 parent 63e6dc6 commit 0e294eb

File tree

6 files changed

+503
-513
lines changed

6 files changed

+503
-513
lines changed

src/codeflare_sdk/cluster/cluster.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -478,11 +478,6 @@ def from_k8_cluster_object(
478478
"containers"
479479
]:
480480
openshift_oauth = "oauth-proxy" in container["name"]
481-
machine_types = (
482-
rc["metadata"]["labels"]["orderedinstance"].split("_")
483-
if "orderedinstance" in rc["metadata"]["labels"]
484-
else []
485-
)
486481

487482
if local_interactive and ingress_domain == None:
488483
ingress_domain = rc["metadata"]["annotations"][

src/codeflare_sdk/templates/base-template.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ spec:
88
- podSets:
99
- replicas: 1
1010
path: template.spec.headGroupSpec.template
11-
- replicas: 3
11+
- replicas: 3
1212
path: template.spec.workerGroupSpecs[0].template
1313
template:
1414
# This config demonstrates KubeRay's Ray autoscaler integration.

src/codeflare_sdk/utils/generate_yaml.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -361,10 +361,10 @@ def enable_local_interactive(components, cluster_name, namespace, ingress_domain
361361
namespace,
362362
ingress_domain,
363363
)
364-
item["generictemplate"]["metadata"]["annotations"][
364+
item["template"]["metadata"]["annotations"][
365365
"sdk.codeflare.dev/local_interactive"
366366
] = "True"
367-
item["generictemplate"]["metadata"]["annotations"][
367+
item["template"]["metadata"]["annotations"][
368368
"sdk.codeflare.dev/ingress_domain"
369369
] = ingress_domain
370370

@@ -373,9 +373,9 @@ def enable_local_interactive(components, cluster_name, namespace, ingress_domain
373373
].get("command")[2] = command
374374

375375

376-
def apply_ingress_domain_annotation(resources, ingress_domain):
377-
item = resources["resources"].get("GenericItems")[0]
378-
item["generictemplate"]["metadata"]["annotations"][
376+
def apply_ingress_domain_annotation(components, ingress_domain):
377+
item = components[0]
378+
item["template"]["metadata"]["annotations"][
379379
"sdk.codeflare.dev/ingress_domain"
380380
] = ingress_domain
381381

@@ -629,7 +629,7 @@ def generate_appwrapper(
629629
ingress_domain,
630630
)
631631
if ingress_domain is not None:
632-
apply_ingress_domain_annotation(resources, ingress_domain)
632+
apply_ingress_domain_annotation(components, ingress_domain)
633633

634634
if local_interactive:
635635
enable_local_interactive(components, cluster_name, namespace, ingress_domain)

0 commit comments

Comments
 (0)