diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 79cae2f0d..25deeb934 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -24,7 +24,7 @@ The code for MCAD/InstaScale resource reconcilliation can be found in the `contr - See `mcad_controller.go` and `instascale_controller.go` ## Building and Deployment -If changes are made in the `api` dir, run: `make manifests` +If changes are made in the `api` dir, or to regenerate config after go code changes, run: `make manifests` - This will generate new CRDs and associated files If changes are made to any Go code (like in the `controllers` dir for example), run: `make` diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml index 691c9dfb4..332ac0531 100644 --- a/config/rbac/role.yaml +++ b/config/rbac/role.yaml @@ -325,7 +325,9 @@ rules: - appwrappers/finalizers - appwrappers/status - queuejobs + - quotasubtrees - schedulingspecs + - xqueuejobs verbs: - create - delete diff --git a/controllers/mcad_controller.go b/controllers/mcad_controller.go index 9dfecc24a..2af14f0e8 100644 --- a/controllers/mcad_controller.go +++ b/controllers/mcad_controller.go @@ -102,7 +102,7 @@ func (r *MCADReconciler) DeleteResource(params *MCADParams, template string, fns // +kubebuilder:rbac:groups=codeflare.codeflare.dev,resources=mcads,verbs=get;list;watch;create;update;patch;delete // +kubebuilder:rbac:groups=codeflare.codeflare.dev,resources=mcads/status,verbs=get;update;patch // +kubebuilder:rbac:groups=codeflare.codeflare.dev,resources=mcads/finalizers,verbs=update -// +kubebuilder:rbac:groups=workload.codeflare.dev,resources=queuejobs;schedulingspecs;appwrappers;appwrappers/finalizers;appwrappers/status,verbs=get;list;watch;create;update;patch;delete;deletecollection +// +kubebuilder:rbac:groups=workload.codeflare.dev,resources=xqueuejobs;queuejobs;schedulingspecs;appwrappers;appwrappers/finalizers;appwrappers/status;quotasubtrees,verbs=get;list;watch;create;update;patch;delete;deletecollection // +kubebuilder:rbac:groups=core,resources=pods;lists;namespaces,verbs=get;list;watch;create;update;patch;delete;deletecollection // +kubebuilder:rbac:groups=core,resources=bindings;pods/binding,verbs=create // +kubebuilder:rbac:groups=core,resources=kube-scheduler,verbs=get;update