Skip to content

Commit f06bddb

Browse files
committed
review comments
1 parent 4169411 commit f06bddb

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

main.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,11 @@ func main() {
9898
QPS: ptr.To(float32(50)),
9999
Burst: ptr.To(int32(100)),
100100
},
101+
AppWrapper: &awconfig.AppWrapperConfig{
102+
ManageJobsWithoutQueueName: true,
103+
StandaloneMode: true, // TODO: Enables AWController to work without Kueue; simplifies testing for now.
104+
},
101105
ControllerManager: config.ControllerManager{
102-
AppWrapper: awconfig.AppWrapperConfig{
103-
ManageJobsWithoutQueueName: true,
104-
StandaloneMode: true, // TODO: Enables AWController to work without Kueue; simplifies testing for now.
105-
},
106106
Metrics: config.MetricsConfiguration{
107107
BindAddress: ":8080",
108108
SecureServing: true,
@@ -163,7 +163,7 @@ func main() {
163163
})
164164
exitOnError(err, "unable to start manager")
165165

166-
exitOnError(awctrl.SetupWithManager(ctx, mgr, &cfg.AppWrapper), "unable to setup AppWrapper controller")
166+
exitOnError(awctrl.SetupWithManager(ctx, mgr, cfg.AppWrapper), "unable to setup AppWrapper controller")
167167

168168
exitOnError(mgr.AddHealthzCheck(cfg.Health.LivenessEndpointName, healthz.Ping), "unable to set up health check")
169169
exitOnError(mgr.AddReadyzCheck(cfg.Health.ReadinessEndpointName, healthz.Ping), "unable to set up ready check")

pkg/config/config.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ type CodeFlareOperatorConfiguration struct {
2929

3030
// ControllerManager returns the configurations for controllers
3131
ControllerManager `json:",inline"`
32+
33+
// AppWrapper contains the AppWrapper controller configuration
34+
AppWrapper *awconfig.AppWrapperConfig `json:"appwrapper,omitempty"`
3235
}
3336

3437
type ControllerManager struct {
35-
// AppWrapper constains the AppWrapper controller configuration
36-
AppWrapper awconfig.AppWrapperConfig
37-
3838
// Metrics contains the controller metrics configuration
3939
// +optional
4040
Metrics MetricsConfiguration `json:"metrics,omitempty"`

0 commit comments

Comments
 (0)