Check if workerGroupSpec is not empty before accessing it

Author: ChristianZaccaria

pkg/controllers/raycluster_webhook.go

@@ -100,24 +100,25 @@ func (w *rayClusterWebhook) Default(ctx context.Context, obj runtime.Object) err
 		}
 
 		// WorkerGroupSpec
-
-		// Append the list of environment variables for the worker container
-		for _, envVar := range envVarList() {
-			rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].Env = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].Env, envVar, withEnvVarName(envVar.Name))
-		}
-
-		// Append the CA volumes
-		for _, caVol := range caVolumes(rayCluster) {
-			rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Volumes = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Volumes, caVol, withVolumeName(caVol.Name))
-		}
-
-		// Append the certificate volume mounts
-		for _, mount := range certVolumeMounts() {
-			rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].VolumeMounts = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].VolumeMounts, mount, byVolumeMountName)
+		if len(rayCluster.Spec.WorkerGroupSpecs) != 0 {
+			// Append the list of environment variables for the worker container
+			for _, envVar := range envVarList() {
+				rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].Env = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].Env, envVar, withEnvVarName(envVar.Name))
+			}
+
+			// Append the CA volumes
+			for _, caVol := range caVolumes(rayCluster) {
+				rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Volumes = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Volumes, caVol, withVolumeName(caVol.Name))
+			}
+
+			// Append the certificate volume mounts
+			for _, mount := range certVolumeMounts() {
+				rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].VolumeMounts = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].VolumeMounts, mount, byVolumeMountName)
+			}
+
+			// Append the create-cert Init Container
+			rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.InitContainers = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.InitContainers, rayWorkerInitContainer(), withContainerName(initContainerName))
 		}
-
-		// Append the create-cert Init Container
-		rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.InitContainers = upsert(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.InitContainers, rayWorkerInitContainer(), withContainerName(initContainerName))
 	}
 
 	return nil
@@ -386,6 +387,10 @@ func validateHeadInitContainer(rayCluster *rayv1.RayCluster, domain string) fiel
 func validateWorkerInitContainer(rayCluster *rayv1.RayCluster) field.ErrorList {
 	var allErrors field.ErrorList
 
+	if len(rayCluster.Spec.WorkerGroupSpecs) == 0 {
+		return allErrors
+	}
+
 	if err := contains(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.InitContainers, rayWorkerInitContainer(), byContainerName,
 		field.NewPath("spec", "workerGroupSpecs", "0", "template", "spec", "initContainers"),
 		"create-cert Init Container is immutable"); err != nil {
@@ -404,10 +409,12 @@ func validateCaVolumes(rayCluster *rayv1.RayCluster) field.ErrorList {
 			"ca-vol and server-cert Secret volumes are immutable"); err != nil {
 			allErrors = append(allErrors, err)
 		}
-		if err := contains(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Volumes, caVol, byVolumeName,
-			field.NewPath("spec", "workerGroupSpecs", "0", "template", "spec", "volumes"),
-			"ca-vol and server-cert Secret volumes are immutable"); err != nil {
-			allErrors = append(allErrors, err)
+		if len(rayCluster.Spec.WorkerGroupSpecs) != 0 {
+			if err := contains(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Volumes, caVol, byVolumeName,
+				field.NewPath("spec", "workerGroupSpecs", "0", "template", "spec", "volumes"),
+				"ca-vol and server-cert Secret volumes are immutable"); err != nil {
+				allErrors = append(allErrors, err)
+			}
 		}
 	}
 
@@ -431,6 +438,10 @@ func validateHeadEnvVars(rayCluster *rayv1.RayCluster) field.ErrorList {
 func validateWorkerEnvVars(rayCluster *rayv1.RayCluster) field.ErrorList {
 	var allErrors field.ErrorList
 
+	if len(rayCluster.Spec.WorkerGroupSpecs) == 0 {
+		return allErrors
+	}
+
 	for _, envVar := range envVarList() {
 		if err := contains(rayCluster.Spec.WorkerGroupSpecs[0].Template.Spec.Containers[0].Env, envVar, byEnvVarName,
 			field.NewPath("spec", "workerGroupSpecs", "0", "template", "spec", "containers", strconv.Itoa(0), "env"),