Skip to content

Commit 3b3ae38

Browse files
committed
fix golangci-lint install rule
1 parent 50c38b9 commit 3b3ae38

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,8 @@ install-yq: $(YQ) ## Download yq locally if necessary
259259
$(YQ): $(LOCALBIN)
260260
test -s $(LOCALBIN)/yq || GOBIN=$(LOCALBIN) go install github.com/mikefarah/yq/v4@$(YQ_VERSION)
261261

262-
.PHONY: install-golangci-lint
263-
install-yq: $(YQ) ## Download golangci-lint locally if necessary
264-
$(GOLANGCI_LINT): $(LOCALBIN)
262+
.PHONY: install-golint
263+
install-golint: $(LOCALBIN)
265264
test -s $(LOCALBIN)/golangci-lint || GOBIN=$(LOCALBIN) go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)
266265

267266
.PHONY: envtest
@@ -389,7 +388,7 @@ verify-imports: openshift-goimports ## Run import verifications.
389388
./hack/verify-imports.sh $(OPENSHIFT-GOIMPORTS)
390389

391390
.PHONY: lint
392-
lint: $(GOLANGCI_LINT) ## Run golangci-lint linter
391+
lint: install-golint ## Run golangci-lint linter
393392
$(GOLANGCI_LINT) run
394393

395394
.PHONY: image-mnist-job-test-build

0 commit comments

Comments
 (0)