Made PR Checks issues clearance

Author: Raghul-M

support/environment_test.go

@@ -63,14 +63,14 @@ func TestGetPyTorchImage(t *testing.T) {
 	}
 }
 
-func TestGetOsdClusterID(t *testing.T) {
-	os.Setenv(OsdClusterID, "my-cluster-id")
-	clusterId, ok := GetOsdClusterId()
+func TestGetClusterID(t *testing.T) {
+	os.Setenv(ClusterID, "my-cluster-id")
+	clusterId, ok := GetClusterId()
 	if !ok {
-		gomega.Expect(ok).To(gomega.BeTrue(), "Expected GetOsdClusterId() to return true, but got false.")
+		gomega.Expect(ok).To(gomega.BeTrue(), "Expected GetClusterId() to return true, but got false.")
 	}
 	if clusterId != "my-cluster-id" {
-		gomega.Expect(clusterId).To(gomega.Equal("my-cluster-id"), "Expected GetOsdClusterId() to return 'my-cluster-id', but got '%s'.", clusterId)
+		gomega.Expect(clusterId).To(gomega.Equal("my-cluster-id"), "Expected GetClusterId() to return 'my-cluster-id', but got '%s'.", clusterId)
 	}
 
 }
@@ -118,7 +118,6 @@ func TestGetClusterType(t *testing.T) {
 			envVarValue: "KIND",
 			expected:    KindCluster,
 		},
-		
 	}
 	ttt := With(t)
 	for _, tt := range tests {

support/machine_test.go

@@ -43,3 +43,124 @@ func TestGetMachineSets(t *testing.T) {
 	g.Expect(machine.Namespace).To(gomega.Equal("openshift-machine-api"))
 
 }
+
+/*
+import (
+
+	"testing"
+
+	"github.com/onsi/gomega"
+	machinev1beta1 "github.com/openshift/api/machine/v1beta1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/client-go/kubernetes/fake"
+
+	"sigs.k8s.io/controller-runtime/pkg/client"
+
+    "k8s.io/client-go/kubernetes"
+
+)
+
+func TestGetMachines(t *testing.T) {
+	g := gomega.NewWithT(t)
+
+	// Create a fake client with test data
+	scheme := runtime.NewScheme()
+	_ = machinev1beta1.AddToScheme(scheme)
+	testmachines := []client.Object{
+		&machinev1beta1.Machine{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "machine-1",
+				Namespace: "default",
+			},
+			// ...
+		},
+		&machinev1beta1.Machine{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "machine-2",
+				Namespace: "default",
+			},
+			// ...
+		},
+	}
+	fakeClient := fake.NewSimpleClientset(testmachines...)
+
+	// Define the machine set name to use in the test
+	machineSetName := "my-machine-set"
+
+	// Create a fake test object with the fake client
+	test := fakeTest{t, fakeClient}
+
+	// Call the GetMachines function and assert the result
+	result := GetMachines(test, machineSetName)
+	g.Expect(result).To(gomega.HaveLen(2))
+	g.Expect(result[0].Name).To(gomega.Equal("machine-1"))
+	g.Expect(result[1].Name).To(gomega.Equal("machine-2"))
+}
+
+// Define a fake test object that implements the Test interface
+type fakeTest struct {
+	*testing.T
+	client kubernetes.Interface
+}
+
+// Implement the Test interface for the fakeTest object
+func (f fakeTest) Client() kubernetes.Interface {
+	return f.client
+}
+*/
+/*
+
+func TestGetMachines(t *testing.T) {
+	g := gomega.NewWithT(t)
+
+	scheme := runtime.NewScheme()
+	_ = machinev1beta1.AddToScheme(scheme)
+	// Create a fake client and add some test data
+	testmachines := []client.Object{
+		&machinev1beta1.Machine{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "machine-1",
+				Namespace: "default",
+			},
+			// ...
+		},
+		&machinev1beta1.Machine{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "machine-2",
+				Namespace: "default",
+			},
+			// ...
+		},
+	}
+	_ = NewFakeKubeClientWithMachines(scheme, testmachines...)
+	// Define the machine set name to use in the test
+	machineSetName := "my-machine-set"
+
+	test := With(t).(*T)
+
+
+
+	// Call the GetMachines function and assert the result
+	result := GetMachines(test, machineSetName)
+	g.Expect(result).To(gomega.HaveLen(3))
+	g.Expect(result[0].Name).To(gomega.Equal("machine-1"))
+	g.Expect(result[1].Name).To(gomega.Equal("machine-2"))
+	}
+
+*/
+/*
+import (
+    "testing"
+	"github.com/stretchr/testify/assert"
+)
+func TestGetMachines(t *testing.T) {
+	t.Run("GetMachines returns machines for a given machine set", func(t *testing.T) {
+		machineSetName := "test-machine-set"
+		test := With(t).(*T)
+		machines := GetMachines(test, machineSetName)
+		assert.Len(t, machines, 1)
+		assert.Equal(t, machines[0].Name, "test-machine")
+	})
+}
+*/

support/ocm_test.go

@@ -1 +1,36 @@
 package support
+/*
+import (
+	"testing"
+
+	"github.com/onsi/gomega"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/kubernetes/fake"
+
+	ocmsdk "github.com/openshift-online/ocm-sdk-go"
+	cmv1 "github.com/openshift-online/ocm-sdk-go/clustersmgmt/v1"
+)
+
+func TestGetMachinePools(t *testing.T) {
+	// Create a fake OpenShift client for testing
+	fakeClient := fake.NewSimpleClientset(&machinePool{
+		MachinePool: &cmv1.MachinePool{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "test-machinepool",
+				Namespace: "test-namespace",
+			},
+		},
+	})
+
+	test := With(t).(*T)
+	test.client = &testClient{
+		core: fakeClient,
+	}
+
+	// Call the GetMachinePools function with the fake client and connection
+	machinePools := GetMachinePools(test, &ocmsdk.Connection{})
+
+	test.Expect(machinePools).Should(gomega.HaveLen(1), "Expected 1 machine pool, but got %d", len(machinePools))
+}
+*/