Fix: cursor on Login button becomes cursor: not-allowed in pristine state

[rajatmohan22]

Fixes #2228

Upon some investigation, I found that the value prop of the input field in a web form is not able to recognize Google Autocomplete with a password manager. Seems like it is bypassing Reacts state management.

screen-capture.webm

Changes:

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

[lindapaiste]

Looks good but let's clean up the import line before merging.

[lindapaiste]

Suggested change

	import React, { useEffect, useState } from 'react';
	import React from 'react';

[rajatmohan22]

Done !

[rajatmohan22]

@lindapaiste, could you please take a look? I've removed unnecessary imports. The only thing I believe needs attention is the 'value' prop storing the user's input. Do you think it's safe to leave it this way, or should I make changes here if necessary?

[lindapaiste]

I don’t think that the value prop is a problem? You can definitely research what the best practices are for dealing with an input type=“password”, but let’s tackle that in a separate PR.

If it’s easy, can you roll back the changes in the package-lock.json file and in the Button file? It’s it’s a pain then no worries.

[rajatmohan22]

@lindapaiste, not a problem at all. I've rolled them back. My apologies for missing that.

[lindapaiste]

We’re just about ready to merge but it’s failing lint checks due to a formatting issue. We use a package called Prettier so that all code is formatted nicely and consistently. Now that you removed one of the destructured properties, Prettier thinks that it should all be on one line instead of on separate lines. If you run the lint-fix command that should take care of it.

[rajatmohan22]

We’re just about ready to merge but it’s failing lint checks due to a formatting issue. We use a package called Prettier so that all code is formatted nicely and consistently. Now that you removed one of the destructured properties, Prettier thinks that it should all be on one line instead of on separate lines. If you run the lint-fix command that should take care of it.

@lindapaiste The test passed! Thanks for the suggestion