From 0a7b2bd6f8ba57f7e52d58404820b7702e62df80 Mon Sep 17 00:00:00 2001 From: kkvanonymous Date: Tue, 24 Nov 2020 09:44:44 +0530 Subject: [PATCH 1/3] Fix PropTypes.object() linting errors --- client/components/mobile/ActionStrip.jsx | 2 +- client/modules/IDE/components/NewFileForm.jsx | 2 +- client/modules/IDE/components/NewFolderForm.jsx | 2 +- client/modules/IDE/pages/IDEView.jsx | 2 +- client/modules/User/components/APIKeyForm.jsx | 4 ++-- client/modules/User/components/AccountForm.jsx | 8 ++++---- client/modules/User/components/LoginForm.jsx | 4 ++-- client/modules/User/components/NewPasswordForm.jsx | 4 ++-- client/modules/User/components/ResetPasswordForm.jsx | 2 +- client/modules/User/components/SignupForm.jsx | 8 ++++---- 10 files changed, 19 insertions(+), 19 deletions(-) diff --git a/client/components/mobile/ActionStrip.jsx b/client/components/mobile/ActionStrip.jsx index 4446d89f6c..6d70b8ba2c 100644 --- a/client/components/mobile/ActionStrip.jsx +++ b/client/components/mobile/ActionStrip.jsx @@ -38,7 +38,7 @@ const ActionStrip = ({ actions }) => ( ActionStrip.propTypes = { actions: PropTypes.arrayOf(PropTypes.shape({ - icon: PropTypes.any, + icon: PropTypes.any, //eslint-disable-line aria: PropTypes.string.isRequired, action: PropTypes.func.isRequired, inverted: PropTypes.bool diff --git a/client/modules/IDE/components/NewFileForm.jsx b/client/modules/IDE/components/NewFileForm.jsx index 4072587972..2e36c9bee8 100644 --- a/client/modules/IDE/components/NewFileForm.jsx +++ b/client/modules/IDE/components/NewFileForm.jsx @@ -58,7 +58,7 @@ class NewFileForm extends React.Component { NewFileForm.propTypes = { fields: PropTypes.shape({ - name: PropTypes.object.isRequired + name: PropTypes.objectOf(PropTypes.shape()) }).isRequired, handleSubmit: PropTypes.func.isRequired, createFile: PropTypes.func.isRequired, diff --git a/client/modules/IDE/components/NewFolderForm.jsx b/client/modules/IDE/components/NewFolderForm.jsx index db3078610f..859774493f 100644 --- a/client/modules/IDE/components/NewFolderForm.jsx +++ b/client/modules/IDE/components/NewFolderForm.jsx @@ -56,7 +56,7 @@ class NewFolderForm extends React.Component { NewFolderForm.propTypes = { fields: PropTypes.shape({ - name: PropTypes.object.isRequired + name: PropTypes.objectOf(PropTypes.shape()) }).isRequired, handleSubmit: PropTypes.func.isRequired, createFolder: PropTypes.func.isRequired, diff --git a/client/modules/IDE/pages/IDEView.jsx b/client/modules/IDE/pages/IDEView.jsx index 8c462203c2..782a46f305 100644 --- a/client/modules/IDE/pages/IDEView.jsx +++ b/client/modules/IDE/pages/IDEView.jsx @@ -495,7 +495,7 @@ IDEView.propTypes = { updatedAt: PropTypes.string, }).isRequired, editorAccessibility: PropTypes.shape({ - lintMessages: PropTypes.array.isRequired, // eslint-disable-line + lintMessages: PropTypes.objectOf(PropTypes.shape()), }).isRequired, preferences: PropTypes.shape({ autosave: PropTypes.bool.isRequired, diff --git a/client/modules/User/components/APIKeyForm.jsx b/client/modules/User/components/APIKeyForm.jsx index e5c7577f47..acdb664d31 100644 --- a/client/modules/User/components/APIKeyForm.jsx +++ b/client/modules/User/components/APIKeyForm.jsx @@ -7,8 +7,8 @@ import CopyableInput from '../../IDE/components/CopyableInput'; import APIKeyList from './APIKeyList'; export const APIKeyPropType = PropTypes.shape({ - id: PropTypes.object.isRequired, // eslint-disable-line - token: PropTypes.object, // eslint-disable-line + id: PropTypes.objectOf(PropTypes.shape()), + token: PropTypes.objectOf(PropTypes.shape()), label: PropTypes.string.isRequired, createdAt: PropTypes.string.isRequired, lastUsedAt: PropTypes.string diff --git a/client/modules/User/components/AccountForm.jsx b/client/modules/User/components/AccountForm.jsx index 9682171b44..00e2c3488d 100644 --- a/client/modules/User/components/AccountForm.jsx +++ b/client/modules/User/components/AccountForm.jsx @@ -109,10 +109,10 @@ function AccountForm(props) { AccountForm.propTypes = { fields: PropTypes.shape({ - username: PropTypes.object.isRequired, // eslint-disable-line - email: PropTypes.object.isRequired, // eslint-disable-line - currentPassword: PropTypes.object.isRequired, // eslint-disable-line - newPassword: PropTypes.object.isRequired, // eslint-disable-line + username: PropTypes.objectOf(PropTypes.shape()), + email: PropTypes.objectOf(PropTypes.shape()), + currentPassword: PropTypes.objectOf(PropTypes.shape()), + newPassword: PropTypes.objectOf(PropTypes.shape()), }).isRequired, user: PropTypes.shape({ verified: PropTypes.string.isRequired, diff --git a/client/modules/User/components/LoginForm.jsx b/client/modules/User/components/LoginForm.jsx index 033416b560..3bf34bdd68 100644 --- a/client/modules/User/components/LoginForm.jsx +++ b/client/modules/User/components/LoginForm.jsx @@ -54,8 +54,8 @@ function LoginForm(props) { LoginForm.propTypes = { fields: PropTypes.shape({ - email: PropTypes.object.isRequired, // eslint-disable-line - password: PropTypes.object.isRequired, // eslint-disable-line + email: PropTypes.objectOf(PropTypes.shape()), + password: PropTypes.objectOf(PropTypes.shape()), }).isRequired, handleSubmit: PropTypes.func.isRequired, validateAndLoginUser: PropTypes.func.isRequired, diff --git a/client/modules/User/components/NewPasswordForm.jsx b/client/modules/User/components/NewPasswordForm.jsx index cf8b3ad9b4..6715c880a6 100644 --- a/client/modules/User/components/NewPasswordForm.jsx +++ b/client/modules/User/components/NewPasswordForm.jsx @@ -47,8 +47,8 @@ function NewPasswordForm(props) { NewPasswordForm.propTypes = { fields: PropTypes.shape({ - password: PropTypes.object.isRequired, // eslint-disable-line - confirmPassword: PropTypes.object.isRequired, // eslint-disable-line + password: PropTypes.objectOf(PropTypes.shape()), + confirmPassword: PropTypes.objectOf(PropTypes.shape()), }).isRequired, handleSubmit: PropTypes.func.isRequired, updatePassword: PropTypes.func.isRequired, diff --git a/client/modules/User/components/ResetPasswordForm.jsx b/client/modules/User/components/ResetPasswordForm.jsx index ccd05ecc95..a42761465d 100644 --- a/client/modules/User/components/ResetPasswordForm.jsx +++ b/client/modules/User/components/ResetPasswordForm.jsx @@ -37,7 +37,7 @@ function ResetPasswordForm(props) { ResetPasswordForm.propTypes = { fields: PropTypes.shape({ - email: PropTypes.object.isRequired + email: PropTypes.objectOf(PropTypes.shape()) }).isRequired, handleSubmit: PropTypes.func.isRequired, initiateResetPassword: PropTypes.func.isRequired, diff --git a/client/modules/User/components/SignupForm.jsx b/client/modules/User/components/SignupForm.jsx index 918e7cb329..43b0ea3549 100644 --- a/client/modules/User/components/SignupForm.jsx +++ b/client/modules/User/components/SignupForm.jsx @@ -83,10 +83,10 @@ function SignupForm(props) { SignupForm.propTypes = { fields: PropTypes.shape({ - username: PropTypes.object.isRequired, // eslint-disable-line - email: PropTypes.object.isRequired, // eslint-disable-line - password: PropTypes.object.isRequired, // eslint-disable-line - confirmPassword: PropTypes.object.isRequired, // eslint-disable-line + username: PropTypes.objectOf(PropTypes.shape()), + email: PropTypes.objectOf(PropTypes.shape()), + password: PropTypes.objectOf(PropTypes.shape()), + confirmPassword: PropTypes.objectOf(PropTypes.shape()), }).isRequired, handleSubmit: PropTypes.func.isRequired, signUpUser: PropTypes.func.isRequired, From 1ecb3db91ddc8f0a73284695d3da52478abf2643 Mon Sep 17 00:00:00 2001 From: kkvanonymous Date: Wed, 25 Nov 2020 10:35:31 +0530 Subject: [PATCH 2/3] Add isRequired in the snippets specified --- client/modules/IDE/components/NewFileForm.jsx | 2 +- client/modules/IDE/components/NewFolderForm.jsx | 2 +- client/modules/IDE/pages/IDEView.jsx | 2 +- client/modules/User/components/APIKeyForm.jsx | 2 +- client/modules/User/components/AccountForm.jsx | 8 ++++---- client/modules/User/components/LoginForm.jsx | 4 ++-- client/modules/User/components/NewPasswordForm.jsx | 4 ++-- client/modules/User/components/ResetPasswordForm.jsx | 2 +- client/modules/User/components/SignupForm.jsx | 8 ++++---- 9 files changed, 17 insertions(+), 17 deletions(-) diff --git a/client/modules/IDE/components/NewFileForm.jsx b/client/modules/IDE/components/NewFileForm.jsx index 2e36c9bee8..712520dd53 100644 --- a/client/modules/IDE/components/NewFileForm.jsx +++ b/client/modules/IDE/components/NewFileForm.jsx @@ -58,7 +58,7 @@ class NewFileForm extends React.Component { NewFileForm.propTypes = { fields: PropTypes.shape({ - name: PropTypes.objectOf(PropTypes.shape()) + name: PropTypes.objectOf(PropTypes.shape()).isRequired }).isRequired, handleSubmit: PropTypes.func.isRequired, createFile: PropTypes.func.isRequired, diff --git a/client/modules/IDE/components/NewFolderForm.jsx b/client/modules/IDE/components/NewFolderForm.jsx index 859774493f..cc602489c6 100644 --- a/client/modules/IDE/components/NewFolderForm.jsx +++ b/client/modules/IDE/components/NewFolderForm.jsx @@ -56,7 +56,7 @@ class NewFolderForm extends React.Component { NewFolderForm.propTypes = { fields: PropTypes.shape({ - name: PropTypes.objectOf(PropTypes.shape()) + name: PropTypes.objectOf(PropTypes.shape()).isRequired }).isRequired, handleSubmit: PropTypes.func.isRequired, createFolder: PropTypes.func.isRequired, diff --git a/client/modules/IDE/pages/IDEView.jsx b/client/modules/IDE/pages/IDEView.jsx index 782a46f305..94a416be88 100644 --- a/client/modules/IDE/pages/IDEView.jsx +++ b/client/modules/IDE/pages/IDEView.jsx @@ -495,7 +495,7 @@ IDEView.propTypes = { updatedAt: PropTypes.string, }).isRequired, editorAccessibility: PropTypes.shape({ - lintMessages: PropTypes.objectOf(PropTypes.shape()), + lintMessages: PropTypes.objectOf(PropTypes.shape()).isRequired, }).isRequired, preferences: PropTypes.shape({ autosave: PropTypes.bool.isRequired, diff --git a/client/modules/User/components/APIKeyForm.jsx b/client/modules/User/components/APIKeyForm.jsx index acdb664d31..f586b41b25 100644 --- a/client/modules/User/components/APIKeyForm.jsx +++ b/client/modules/User/components/APIKeyForm.jsx @@ -7,7 +7,7 @@ import CopyableInput from '../../IDE/components/CopyableInput'; import APIKeyList from './APIKeyList'; export const APIKeyPropType = PropTypes.shape({ - id: PropTypes.objectOf(PropTypes.shape()), + id: PropTypes.objectOf(PropTypes.shape()).isRequired, token: PropTypes.objectOf(PropTypes.shape()), label: PropTypes.string.isRequired, createdAt: PropTypes.string.isRequired, diff --git a/client/modules/User/components/AccountForm.jsx b/client/modules/User/components/AccountForm.jsx index 00e2c3488d..4432efbf7a 100644 --- a/client/modules/User/components/AccountForm.jsx +++ b/client/modules/User/components/AccountForm.jsx @@ -109,10 +109,10 @@ function AccountForm(props) { AccountForm.propTypes = { fields: PropTypes.shape({ - username: PropTypes.objectOf(PropTypes.shape()), - email: PropTypes.objectOf(PropTypes.shape()), - currentPassword: PropTypes.objectOf(PropTypes.shape()), - newPassword: PropTypes.objectOf(PropTypes.shape()), + username: PropTypes.objectOf(PropTypes.shape()).isRequired, + email: PropTypes.objectOf(PropTypes.shape()).isRequired, + currentPassword: PropTypes.objectOf(PropTypes.shape()).isRequired, + newPassword: PropTypes.objectOf(PropTypes.shape()).isRequired, }).isRequired, user: PropTypes.shape({ verified: PropTypes.string.isRequired, diff --git a/client/modules/User/components/LoginForm.jsx b/client/modules/User/components/LoginForm.jsx index 3bf34bdd68..3c969ddd7a 100644 --- a/client/modules/User/components/LoginForm.jsx +++ b/client/modules/User/components/LoginForm.jsx @@ -54,8 +54,8 @@ function LoginForm(props) { LoginForm.propTypes = { fields: PropTypes.shape({ - email: PropTypes.objectOf(PropTypes.shape()), - password: PropTypes.objectOf(PropTypes.shape()), + email: PropTypes.objectOf(PropTypes.shape()).isRequired, + password: PropTypes.objectOf(PropTypes.shape()).isRequired, }).isRequired, handleSubmit: PropTypes.func.isRequired, validateAndLoginUser: PropTypes.func.isRequired, diff --git a/client/modules/User/components/NewPasswordForm.jsx b/client/modules/User/components/NewPasswordForm.jsx index 6715c880a6..1a1e0386c1 100644 --- a/client/modules/User/components/NewPasswordForm.jsx +++ b/client/modules/User/components/NewPasswordForm.jsx @@ -47,8 +47,8 @@ function NewPasswordForm(props) { NewPasswordForm.propTypes = { fields: PropTypes.shape({ - password: PropTypes.objectOf(PropTypes.shape()), - confirmPassword: PropTypes.objectOf(PropTypes.shape()), + password: PropTypes.objectOf(PropTypes.shape()).isRequired, + confirmPassword: PropTypes.objectOf(PropTypes.shape()).isRequired, }).isRequired, handleSubmit: PropTypes.func.isRequired, updatePassword: PropTypes.func.isRequired, diff --git a/client/modules/User/components/ResetPasswordForm.jsx b/client/modules/User/components/ResetPasswordForm.jsx index a42761465d..82b399cd9e 100644 --- a/client/modules/User/components/ResetPasswordForm.jsx +++ b/client/modules/User/components/ResetPasswordForm.jsx @@ -37,7 +37,7 @@ function ResetPasswordForm(props) { ResetPasswordForm.propTypes = { fields: PropTypes.shape({ - email: PropTypes.objectOf(PropTypes.shape()) + email: PropTypes.objectOf(PropTypes.shape()).isRequired }).isRequired, handleSubmit: PropTypes.func.isRequired, initiateResetPassword: PropTypes.func.isRequired, diff --git a/client/modules/User/components/SignupForm.jsx b/client/modules/User/components/SignupForm.jsx index 43b0ea3549..b8e7b710f8 100644 --- a/client/modules/User/components/SignupForm.jsx +++ b/client/modules/User/components/SignupForm.jsx @@ -83,10 +83,10 @@ function SignupForm(props) { SignupForm.propTypes = { fields: PropTypes.shape({ - username: PropTypes.objectOf(PropTypes.shape()), - email: PropTypes.objectOf(PropTypes.shape()), - password: PropTypes.objectOf(PropTypes.shape()), - confirmPassword: PropTypes.objectOf(PropTypes.shape()), + username: PropTypes.objectOf(PropTypes.shape()).isRequired, + email: PropTypes.objectOf(PropTypes.shape()).isRequired, + password: PropTypes.objectOf(PropTypes.shape()).isRequired, + confirmPassword: PropTypes.objectOf(PropTypes.shape()).isRequired, }).isRequired, handleSubmit: PropTypes.func.isRequired, signUpUser: PropTypes.func.isRequired, From 5c3d823fea3c3d756a8af987123d86ec6595dde8 Mon Sep 17 00:00:00 2001 From: Cassie Tarakajian Date: Wed, 25 Nov 2020 13:53:40 -0500 Subject: [PATCH 3/3] [#1514] Update PropType for ActionStrip.icon --- client/components/mobile/ActionStrip.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/components/mobile/ActionStrip.jsx b/client/components/mobile/ActionStrip.jsx index 6d70b8ba2c..65b7ea8c41 100644 --- a/client/components/mobile/ActionStrip.jsx +++ b/client/components/mobile/ActionStrip.jsx @@ -38,7 +38,7 @@ const ActionStrip = ({ actions }) => ( ActionStrip.propTypes = { actions: PropTypes.arrayOf(PropTypes.shape({ - icon: PropTypes.any, //eslint-disable-line + icon: PropTypes.component, aria: PropTypes.string.isRequired, action: PropTypes.func.isRequired, inverted: PropTypes.bool