diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index fc813e0cde..06adec0923 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -18,7 +18,7 @@ Hello! We welcome community contributions to the p5.js Web Editor. Contributing ## Code of Conduct -Please follow the guidelines in the [Code of Conduct](https://github.com/processing/p5.js-web-editor/blob/master/.github/CODE_OF_CONDUCT.md). +Please follow the guidelines in the [Code of Conduct](https://github.com/processing/p5.js-web-editor/blob/develop/.github/CODE_OF_CONDUCT.md). ## How Can I Contribute? If you're new to open source, [read about how to contribute to open source](https://opensource.guide/how-to-contribute/). @@ -60,7 +60,7 @@ If you feel like an issue is tagged incorrectly (e.g. it's low priority and you If you'd like to work on an issue, please comment on it to let the maintainers know, so that they can assign it to you. If someone else has already commented and taken up that issue, please refrain from working on it and submitting a PR without asking the maintainers as it leads to unnecessary duplication of effort. -Then, look at the [development guide](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/development.md) for instructions on how to install the project locally and follow the right development workflow. +Then, look at the [development guide](https://github.com/processing/p5.js-web-editor/blob/develop/developer_docs/development.md) for instructions on how to install the project locally and follow the right development workflow. ### Contribution Guides diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 95cb6f48d7..efbfd96924 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,5 +3,5 @@ Fixes #issue-number I have verified that this pull request: * [ ] has no linting errors (`npm run lint`) -* [ ] is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too) -* [ ] is descriptively named and links to an issue number, i.e. `Fixes #123` \ No newline at end of file +* [ ] is from a uniquely-named feature branch and has been rebased on top of the latest `develop` branch. (If I was asked to make more changes, I have made sure to rebase onto `develop` then too) +* [ ] is descriptively named and links to an issue number, i.e. `Fixes #123` diff --git a/.github/config.yml b/.github/config.yml index ab6fa5c5ad..c104c86c8e 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -10,8 +10,8 @@ newIssueWelcomeComment: > # Comment to be posted to on PRs from first time contributors in your repository newPRWelcomeComment: > - πŸŽ‰ Thanks for opening this pull request! Please check out our [contributing guidelines](https://github.com/processing/p5.js-web-editor/blob/master/.github/CONTRIBUTING.md) if you haven't already. + πŸŽ‰ Thanks for opening this pull request! Please check out our [contributing guidelines](https://github.com/processing/p5.js-web-editor/blob/develop/.github/CONTRIBUTING.md) if you haven't already. # Configuration for first-pr-merge - https://github.com/behaviorbot/first-pr-merge -# Comment to be posted to on pull requests merged by a first time user \ No newline at end of file +# Comment to be posted to on pull requests merged by a first time user diff --git a/README.md b/README.md index 84e9427523..fe5cbd47d8 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ Documentation is also available in the following languages: -[ν•œκ΅­μ–΄](https://github.com/processing/p5.js-web-editor/blob/master/translations/ko) +[ν•œκ΅­μ–΄](https://github.com/processing/p5.js-web-editor/blob/develop/translations/ko) ## Welcome! πŸ‘‹πŸ‘‹πŸΏπŸ‘‹πŸ½πŸ‘‹πŸ»πŸ‘‹πŸΎπŸ‘‹πŸΌ @@ -23,7 +23,7 @@ All contributors to the p5.js Web Editor are expected to follow the [Code of Con The p5.js Web Editor is a collaborative project created by many individuals, and you are invited to help. All types of involvement are welcome! Please check out the [contribution guide](./.github/CONTRIBUTING.md) for more details. -Developers, check the [developer docs](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/) details about contributing code, bug fixes, and documentation. To start writing code, a great place to start is the [development guide](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/development.md). +Developers, check the [developer docs](https://github.com/processing/p5.js-web-editor/blob/develop/developer_docs/) details about contributing code, bug fixes, and documentation. To start writing code, a great place to start is the [development guide](https://github.com/processing/p5.js-web-editor/blob/develop/developer_docs/development.md). ## Issues diff --git a/developer_docs/README.md b/developer_docs/README.md index c919365318..d47fb96568 100644 --- a/developer_docs/README.md +++ b/developer_docs/README.md @@ -1,7 +1,7 @@ This folder contains documents intended for developers of the p5.js Web Editor. ## List of Documents -* [Contribution Guide](https://github.com/processing/p5.js-web-editor/blob/master/.github/CONTRIBUTING.md) - A place to get started! +* [Contribution Guide](https://github.com/processing/p5.js-web-editor/blob/develop/.github/CONTRIBUTING.md) - A place to get started! * [Installation](installation.md) - A guide for setting up your development environment * [Development](development.md) - A guide for adding code to the web editor * [Preparing a pull-request](preparing_a_pull_request.md) - Instructions for how to make a pull-request @@ -11,6 +11,6 @@ This folder contains documents intended for developers of the p5.js Web Editor. * [Release](./release.md) - A guide to creating a production release. ## Documents to Create -* Design Principles - reference [p5.js design principles](https://github.com/processing/p5.js/edit/master/contributor_docs/design_principles.md) -* Issue Labels - reference [p5.js issue labels](https://github.com/processing/p5.js/blob/master/contributor_docs/issue_labels.md) +* Design Principles - reference [p5.js design principles](https://github.com/processing/p5.js/edit/develop/contributor_docs/design_principles.md) +* Issue Labels - reference [p5.js issue labels](https://github.com/processing/p5.js/blob/develop/contributor_docs/issue_labels.md) * File Structure - An explanation of the file structure of this application. diff --git a/developer_docs/accessibility.md b/developer_docs/accessibility.md index 92942607be..32047a964b 100644 --- a/developer_docs/accessibility.md +++ b/developer_docs/accessibility.md @@ -8,13 +8,13 @@ The code for the p5.js web editor adheres to web accessibility standards. The fo * Screen Readers are an assistive technology for vision loss which helps users to navigate a web page. They are able to prioritize content based on the semantic meaning of HTML tags. Therefore, it is important to use specific tags, such as `nav`, `ul`, `li`, `section`, and so on. `div` is the least screen reader friendly tag. For example, [here is the semantic meaning of the `body` tag](http://html5doctor.com/element-index/#body) * All buttons/links/windows need to be accessible by the keyboard ( By tabbing, pressing space etc.) -* In cases where tags are not screen reader friendly, we can take advantage of [tabIndex](http://webaim.org/techniques/keyboard/tabindex). Using tabIndex ensures that all elements are accessible via keyboard. [code example](https://github.com/processing/p5.js-web-editor/blob/master/client/modules/IDE/components/Editor.jsx#L249) -* When opening a new window or pop up window, ensure the keyboard focus also moves to the new window. [code example](https://github.com/processing/p5.js-web-editor/blob/master/client/modules/IDE/components/NewFileForm.jsx#L16) +* In cases where tags are not screen reader friendly, we can take advantage of [tabIndex](http://webaim.org/techniques/keyboard/tabindex). Using tabIndex ensures that all elements are accessible via keyboard. [code example](https://github.com/processing/p5.js-web-editor/blob/develop/client/modules/IDE/components/Editor.jsx#L249) +* When opening a new window or pop up window, ensure the keyboard focus also moves to the new window. [code example](https://github.com/processing/p5.js-web-editor/blob/develop/client/modules/IDE/components/NewFileForm.jsx#L16) **Labeling** -* When creating button icons, images, or something without text (this does not include an HTML5 `