Skip to content

added preview for sketches #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

added preview for sketches #2763

wants to merge 8 commits into from

Conversation

KrishavRajSingh
Copy link

Fixes #2532

I used the method that was used in #2168 and succeeded in making the previews, but it wasn't working for some sketches, especially the ones with images.

Changes:
1> Added a MenuItem for Preview in Sketch's Dropdown list.
2> Created a ExamplePreview Component to view the Preview. Used EmbedFrame to preview the sketches but it is not working for all the sketches. Need help in this.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@KrishavRajSingh KrishavRajSingh mentioned this pull request Dec 23, 2023
Open
@lindapaiste
Copy link
Collaborator

Thanks for working on this! I’ll take a look after the holidays and see if I can figure out the problems.

lindapaiste
lindapaiste suggested changes Dec 28, 2023
View reviewed changes
@lindapaiste
Copy link
Collaborator

I pushed some changes to your branch. It seems like the sketch preview works now but we probably need to think through the UI a bit, like we probably want an "x" button over the preview or some other easy way to close.

@KrishavRajSingh
Copy link
Author

I pushed some changes to your branch. It seems like the sketch preview works now but we probably need to think through the UI a bit, like we probably want an "x" button over the preview or some other easy way to close.

Yeah Sure, I will make the change

@KrishavRajSingh KrishavRajSingh marked this pull request as ready for review January 11, 2024 14:10
@raclim raclim added the Feature Request Proposal for adding a new functionality label Jan 26, 2024
@raclim
Copy link
Collaborator

raclim commented Jul 3, 2024

Thanks so much for your work on this!

Since it's been a while since this PR was submitted and I think that the UI for this issue might need more thought, I'm going to close this for now. I'm really sorry that we couldn't get this in, but please feel free to revisit this PR when further UI updates are fleshed out or check out our other issues!

@raclim raclim closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste requested changes

Assignees
No one assigned
Labels
Feature Request Proposal for adding a new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding examples preview
3 participants
@KrishavRajSingh @lindapaiste @raclim