🐛 fix filename allowing empty/invalid strings

ghalestrilo · ghalestrilo · commit fe9d75be8edb · 2020-04-16T13:08:30.000-03:00
diff --git a/client/modules/IDE/components/FileNode.jsx b/client/modules/IDE/components/FileNode.jsx
@@ -49,7 +49,7 @@ export class FileNode extends React.Component {
   }
 
   get updatedName() {
-    return this.state.updatedName || this.props.name;
+    return this.state.updatedName;
   }
 
   commitFileNameChange() {
@@ -92,7 +92,6 @@ export class FileNode extends React.Component {
     const hasOnlyExtension = newFileExtension && newFileName === newFileExtension[0];
     if (hasEmptyFilename || hasNoExtension || notSameExtension || hasOnlyExtension || hasExtensionIfFolder) {
       this.setState({ updatedName: this.originalFileName });
-      this.props.updateFileName(this.props.id, this.originalFileName);
     } else this.commitFileNameChange();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export class FileNode extends React.Component {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`get updatedName() {`
`52`		`- return this.state.updatedName \|\| this.props.name;`
	`52`	`+ return this.state.updatedName;`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`commitFileNameChange() {`
`@@ -92,7 +92,6 @@ export class FileNode extends React.Component {`
`92`	`92`	`const hasOnlyExtension = newFileExtension && newFileName === newFileExtension[0];`
`93`	`93`	`if (hasEmptyFilename \|\| hasNoExtension \|\| notSameExtension \|\| hasOnlyExtension \|\| hasExtensionIfFolder) {`
`94`	`94`	`this.setState({ updatedName: this.originalFileName });`
`95`		`- this.props.updateFileName(this.props.id, this.originalFileName);`
`96`	`95`	`} else this.commitFileNameChange();`
`97`	`96`	`}`
`98`	`97`