Skip to content

Commit fd06f5f

Browse files
committed
Merge branch 'develop' into login-signup-issue
2 parents e83ac7b + fffe0f8 commit fd06f5f

File tree

182 files changed

+28039
-11166
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

182 files changed

+28039
-11166
lines changed

.babelrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"env": {
77
"production": {
88
"plugins": [
9+
"babel-plugin-styled-components",
910
"transform-react-remove-prop-types",
1011
"@babel/plugin-transform-react-constant-elements",
1112
"@babel/plugin-transform-react-inline-elements",
@@ -48,6 +49,7 @@
4849
},
4950
"development": {
5051
"plugins": [
52+
"babel-plugin-styled-components",
5153
"react-hot-loader/babel"
5254
]
5355
}

.env.example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ API_URL=/editor
22
AWS_ACCESS_KEY=<your-aws-access-key>
33
AWS_REGION=<your-aws-region>
44
AWS_SECRET_KEY=<your-aws-secret-key>
5+
CORS_ALLOW_LOCALHOST=true
56
EMAIL_SENDER=<transactional-email-sender>
67
EMAIL_VERIFY_SECRET_TOKEN=whatever_you_want_this_to_be_it_only_matters_for_production
78
EXAMPLE_USER_EMAIL=examples@p5js.org

.eslintrc

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,13 @@
7777
"__SERVER__": true,
7878
"__DISABLE_SSR__": true,
7979
"__DEVTOOLS__": true
80-
}
80+
},
81+
"overrides": [
82+
{
83+
"files": ["*.stories.jsx"],
84+
"rules": {
85+
"import/no-extraneous-dependencies": "off"
86+
}
87+
}
88+
]
8189
}

.github/CONTRIBUTING.md

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ Hello! We welcome community contributions to the p5.js Web Editor. Contributing
1515
- [Issue Search and Tagging](#issue-search-and-tagging)
1616
- [Beginning Work](#beginning-work)
1717
- [Contribution Guides](#contribution-guides)
18-
- [Writing Commit Messages](#writing-commit-messages)
19-
- [Tips](#tips)
2018

2119
## Code of Conduct
2220

@@ -62,45 +60,9 @@ If you feel like an issue is tagged incorrectly (e.g. it's low priority and you
6260

6361
If you'd like to work on an issue, please comment on it to let the maintainers know, so that they can assign it to you. If someone else has already commented and taken up that issue, please refrain from working on it and submitting a PR without asking the maintainers as it leads to unnecessary duplication of effort.
6462

65-
Then, follow the [installation guide](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/installation.md) to get the project building and working on your computer.
63+
Then, look at the [development guide](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/development.md) for instructions on how to install the project locally and follow the right development workflow.
6664

6765
### Contribution Guides
6866

6967
* [https://guides.github.com/activities/hello-world/](https://guides.github.com/activities/hello-world/)
7068
* [https://guides.github.com/activities/forking/](https://guides.github.com/activities/forking/)
71-
72-
## Writing Commit Messages
73-
74-
Good commit messages serve at least three important purposes:
75-
76-
* They speed up the reviewing process.
77-
* They help us write good release notes.
78-
* They help future maintainers understand your change and the reasons behind it.
79-
80-
Structure your commit message like this:
81-
82-
```
83-
Short (50 chars or less) summary of changes ( involving Fixes #Issue-number keyword )
84-
85-
More detailed explanatory text, if necessary. Wrap it to about 72
86-
characters or so. In some contexts, the first line is treated as the
87-
subject of an email and the rest of the text as the body. The blank
88-
line separating the summary from the body is critical (unless you omit
89-
the body entirely); tools like rebase can get confused if you run the
90-
two together.
91-
92-
Further paragraphs come after blank lines.
93-
94-
- Bullet points are okay, too
95-
96-
- Typically a hyphen or asterisk is used for the bullet, preceded by a
97-
single space, with blank lines in between, but conventions vary here
98-
```
99-
100-
* Write the summary line and description of what you have done in the imperative mode, that is as if you were commanding someone. Start the line with "Fix", "Add", "Change" instead of "Fixed", "Added", "Changed".
101-
* Always leave the second line blank.
102-
* Be as descriptive as possible in the description. It helps reasoning about the intention of commits and gives more context about why changes happened.
103-
104-
## Tips
105-
106-
* If it seems difficult to summarize what your commit does, it may be because it includes several logical changes or bug fixes, and are better split up into several commits using `git add -p`.

.github/FUNDING.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
custom: https://processingfoundation.org/support
1+
github: processing
2+
custom: https://processingfoundation.org/

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
Fixes #issue-number
2+
13
I have verified that this pull request:
24

35
* [ ] has no linting errors (`npm run lint`)

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,5 @@ cert_chain.crt
1717
localhost.crt
1818
localhost.key
1919
privkey.pem
20+
21+
storybook-static

.storybook/main.js

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
const path = require('path');
2+
3+
module.exports = {
4+
stories: ['../client/**/*.stories.(jsx|mdx)'],
5+
addons: [
6+
'@storybook/addon-actions',
7+
'@storybook/addon-docs',
8+
'@storybook/addon-knobs',
9+
'@storybook/addon-links',
10+
'storybook-addon-theme-playground/dist/register'
11+
],
12+
webpackFinal: async config => {
13+
// do mutation to the config
14+
15+
const rules = config.module.rules;
16+
17+
// modify storybook's file-loader rule to avoid conflicts with svgr
18+
const fileLoaderRule = rules.find(rule => rule.test.test('.svg'));
19+
fileLoaderRule.exclude = path.resolve(__dirname, '../client');
20+
21+
// use svgr for svg files
22+
rules.push({
23+
test: /\.svg$/,
24+
use: ["@svgr/webpack"],
25+
})
26+
27+
return config;
28+
},
29+
};

.storybook/preview.js

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
import React from 'react';
2+
import { addDecorator, addParameters } from '@storybook/react';
3+
import { withKnobs } from "@storybook/addon-knobs";
4+
import { withThemePlayground } from 'storybook-addon-theme-playground';
5+
import { ThemeProvider } from "styled-components";
6+
7+
import theme, { Theme } from '../client/theme';
8+
9+
addDecorator(withKnobs);
10+
11+
const themeConfigs = Object.values(Theme).map(
12+
name => {
13+
return { name, theme: theme[name] };
14+
}
15+
);
16+
17+
addDecorator(withThemePlayground({
18+
theme: themeConfigs,
19+
provider: ThemeProvider
20+
}));
21+
22+
addParameters({
23+
options: {
24+
/**
25+
* display the top-level grouping as a "root" in the sidebar
26+
*/
27+
showRoots: true,
28+
},
29+
})
30+
31+
// addDecorator(storyFn => <ThemeProvider theme={theme}>{storyFn()}</ThemeProvider>);

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,13 @@ deploy:
3737
script: ./deploy.sh
3838
skip_cleanup: true
3939
on:
40-
branch: master
40+
branch: release
41+
tags: true
4142
- provider: script
4243
script: ./deploy_staging.sh
4344
skip_cleanup: true
4445
on:
45-
branch: feature/public-api
46+
branch: develop
4647

4748
env:
4849
global:

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ COPY .babelrc index.js nodemon.json ./
1414
COPY ./webpack ./webpack
1515
COPY client ./client
1616
COPY server ./server
17+
COPY translations/locales ./translations/locales
1718
CMD ["npm", "start"]
1819

1920
FROM development as build

0 commit comments

Comments
 (0)