Skip to content

Commit f2ed92e

Browse files
committed
confusing icons hover issue fix #2255
1 parent 4eb06ff commit f2ed92e

File tree

2 files changed

+17
-25
lines changed

2 files changed

+17
-25
lines changed

client/modules/IDE/components/QuickAddList/Icons.jsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ const Icons = ({ isAdded }) => {
2020
aria-label="Descending"
2121
focusable="false"
2222
/>
23-
<CheckIcon
24-
className="quick-add__in-icon"
25-
role="img"
26-
aria-label="Descending"
27-
focusable="false"
28-
/>
2923
<CloseIcon
3024
className="quick-add__add-icon"
3125
role="img"

client/styles/components/_quick-add.scss

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,11 @@
8585
transform: rotate(45deg);
8686
}
8787

88-
.quick-add__item:hover,
89-
.quick-add__item-toggle:hover,
88+
.quick-add__item,
89+
.quick-add__item-toggle,
9090
.quick-add__item-toggle:focus {
9191
cursor: pointer;
92+
9293
@include themify() {
9394
& .quick-add__icon path {
9495
fill: getThemifyVariable('table-button-hover-color');
@@ -98,28 +99,25 @@
9899
fill: getThemifyVariable('table-button-background-hover-color');
99100
}
100101
}
102+
}
101103

102-
& .quick-add__in-icon {
103-
display: none;
104+
.quick-add__icon--in-collection {
105+
.quick-add__remove-icon {
106+
display: inline-block;
104107
}
105108

106-
& .quick-add__icon--in-collection {
107-
.quick-add__remove-icon {
108-
display: inline-block;
109-
}
110-
111-
.quick-add__add-icon {
112-
display: none;
113-
}
109+
.quick-add__add-icon {
110+
display: none;
114111
}
112+
}
115113

116-
& .quick-add__icon--not-in-collection {
117-
.quick-add__add-icon {
118-
display: inline-block;
119-
}
114+
.quick-add__icon--not-in-collection {
115+
.quick-add__add-icon {
116+
display: inline-block;
117+
}
120118

121-
.quick-add__remove-icon {
122-
display: none;
123-
}
119+
.quick-add__remove-icon {
120+
display: none;
124121
}
125122
}
123+

0 commit comments

Comments
 (0)