Skip to content

Commit db43b04

Browse files
authored
Merge branch 'develop' into styled-test
2 parents badf56e + db23e7a commit db43b04

File tree

3 files changed

+5
-26
lines changed

3 files changed

+5
-26
lines changed

client/components/Nav.jsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -867,8 +867,6 @@ Nav.propTypes = {
867867
cmController: PropTypes.shape({
868868
tidyCode: PropTypes.func,
869869
showFind: PropTypes.func,
870-
findNext: PropTypes.func,
871-
findPrev: PropTypes.func,
872870
showReplace: PropTypes.func,
873871
getContent: PropTypes.func
874872
}),

client/modules/IDE/components/Editor.jsx

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ class Editor extends React.Component {
8585
}
8686
}, 2000);
8787
this.showFind = this.showFind.bind(this);
88-
this.findNext = this.findNext.bind(this);
89-
this.findPrev = this.findPrev.bind(this);
9088
this.showReplace = this.showReplace.bind(this);
9189
this.getContent = this.getContent.bind(this);
9290
}
@@ -149,8 +147,8 @@ class Editor extends React.Component {
149147
[`${metaKey}-Enter`]: () => null,
150148
[`Shift-${metaKey}-Enter`]: () => null,
151149
[`${metaKey}-F`]: 'findPersistent',
152-
[`${metaKey}-G`]: 'findNext',
153-
[`Shift-${metaKey}-G`]: 'findPrev',
150+
[`${metaKey}-G`]: 'findPersistentNext',
151+
[`Shift-${metaKey}-G`]: 'findPersistentPrev',
154152
[replaceCommand]: 'replace'
155153
});
156154

@@ -196,8 +194,6 @@ class Editor extends React.Component {
196194
this.props.provideController({
197195
tidyCode: this.tidyCode,
198196
showFind: this.showFind,
199-
findNext: this.findNext,
200-
findPrev: this.findPrev,
201197
showReplace: this.showReplace,
202198
getContent: this.getContent
203199
});
@@ -317,16 +313,6 @@ class Editor extends React.Component {
317313
return updatedFile;
318314
}
319315

320-
findPrev() {
321-
this._cm.focus();
322-
this._cm.execCommand('findPrev');
323-
}
324-
325-
findNext() {
326-
this._cm.focus();
327-
this._cm.execCommand('findNext');
328-
}
329-
330316
showFind() {
331317
this._cm.execCommand('findPersistent');
332318
}

client/modules/IDE/pages/IDEView.jsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,6 @@ class IDEView extends React.Component {
101101
if (nextProps.location !== this.props.location) {
102102
this.props.setPreviousPath(this.props.location.pathname);
103103
}
104-
105-
if (this.props.ide.consoleIsExpanded !== nextProps.ide.consoleIsExpanded) {
106-
this.setState({
107-
consoleSize: nextProps.ide.consoleIsExpanded ? 150 : 29
108-
});
109-
}
110-
111104
if (this.props.ide.sidebarIsExpanded !== nextProps.ide.sidebarIsExpanded) {
112105
this.setState({
113106
sidebarSize: nextProps.ide.sidebarIsExpanded ? 160 : 20
@@ -337,7 +330,9 @@ class IDEView extends React.Component {
337330
<SplitPane
338331
split="horizontal"
339332
primary="second"
340-
size={this.state.consoleSize}
333+
size={
334+
this.props.ide.consoleIsExpanded ? this.state.consoleSize : 29
335+
}
341336
minSize={29}
342337
onChange={(size) => this.setState({ consoleSize: size })}
343338
allowResize={this.props.ide.consoleIsExpanded}

0 commit comments

Comments
 (0)