Merge pull request #1469 from saijatin28/bugfix-collections_#sketchesSorting

catarak · web-flow · commit dab315cf1c68 · 2020-06-29T16:02:07.000-04:00
bugfix Collections Sorting - # of sketches is incorrect #1441
diff --git a/client/modules/IDE/selectors/collections.js b/client/modules/IDE/selectors/collections.js
@@ -37,6 +37,11 @@ const getSortedCollections = createSelector(
         return orderBy(collections, 'name', 'desc');
       }
       return orderBy(collections, 'name', 'asc');
+    } else if (field === 'numItems') {
+      if (direction === DIRECTION.DESC) {
+        return orderBy(collections, 'items.length', 'desc');
+      }
+      return orderBy(collections, 'items.length', 'asc');
     }
     const sortedCollections = [...collections].sort((a, b) => {
       const result =

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,11 @@ const getSortedCollections = createSelector(`
`37`	`37`	`return orderBy(collections, 'name', 'desc');`
`38`	`38`	`}`
`39`	`39`	`return orderBy(collections, 'name', 'asc');`
	`40`	`+ } else if (field === 'numItems') {`
	`41`	`+ if (direction === DIRECTION.DESC) {`
	`42`	`+ return orderBy(collections, 'items.length', 'desc');`
	`43`	`+ }`
	`44`	`+ return orderBy(collections, 'items.length', 'asc');`
`40`	`45`	`}`
`41`	`46`	`const sortedCollections = [...collections].sort((a, b) => {`
`42`	`47`	`const result =`