Skip to content

Commit be906c7

Browse files
committed
[#1654] Scroll content in overlay rather than header and content
1 parent b4c2840 commit be906c7

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

client/styles/components/_keyboard-shortcuts.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
padding: #{20 / $base-font-size}rem;
33
padding-bottom: #{40 / $base-font-size}rem;
44
width: #{450 / $base-font-size}rem;
5+
overflow-y: scroll;
56
}
67

78
.keyboard-shortcuts-note {

client/styles/components/_overlay.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
max-height: 80%;
2626
max-width: 65%;
2727
position: relative;
28-
overflow-y: scroll;
2928
}
3029

3130
.overlay__header {

client/styles/components/_preferences.scss

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,23 @@
22
width: 100%;
33
width: #{640 / $base-font-size}rem;
44
max-width: 100%;
5-
min-height: #{460 / $base-font-size}rem;
65
max-height: 100%;
76
z-index: 9999;
87
padding: 0 #{20 / $base-font-size}rem #{2 / $base-font-size}rem #{20 /
98
$base-font-size}rem;
109
display: flex;
1110
flex-direction: column;
1211
outline: none;
12+
height: calc(80vh - #{65 / $base-font-size}rem);
13+
max-height: #{460 / $base-font-size}rem;
14+
& .react-tabs {
15+
max-height: 100%;
16+
display: flex;
17+
flex-direction: column;
18+
}
19+
& .react-tabs__tab-panel {
20+
overflow-y: scroll;
21+
}
1322
}
1423

1524
.preferences__exit-button {

0 commit comments

Comments
 (0)