Skip to content

Commit 9cdbb8b

Browse files
authored
Merge pull request #2230 from lindapaiste/fix/pw-autocomplete
Add autocomplete attributes to password forms - Fixes #2229
2 parents 613bb86 + cb0cc2e commit 9cdbb8b

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

client/modules/User/components/AccountForm.jsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,9 @@ function AccountForm() {
7474
<input
7575
className="form__input"
7676
aria-label={t('AccountForm.EmailARIA')}
77-
type="text"
77+
type="email"
7878
id="email"
79+
autoComplete="email"
7980
{...field.input}
8081
/>
8182
{field.meta.touched && field.meta.error && (
@@ -117,6 +118,7 @@ function AccountForm() {
117118
aria-label={t('AccountForm.UserNameARIA')}
118119
type="text"
119120
id="username"
121+
autoComplete="username"
120122
{...field.input}
121123
/>
122124
{field.meta.touched && field.meta.error && (
@@ -136,6 +138,7 @@ function AccountForm() {
136138
aria-label={t('AccountForm.CurrentPasswordARIA')}
137139
type="password"
138140
id="currentPassword"
141+
autoComplete="current-password"
139142
{...field.input}
140143
/>
141144
{field.meta.touched && field.meta.error && (
@@ -155,6 +158,7 @@ function AccountForm() {
155158
aria-label={t('AccountForm.NewPasswordARIA')}
156159
type="password"
157160
id="newPassword"
161+
autoComplete="new-password"
158162
{...field.input}
159163
/>
160164
{field.meta.touched && field.meta.error && (

client/modules/User/components/LoginForm.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ function LoginForm() {
3939
aria-label={t('LoginForm.UsernameOrEmailARIA')}
4040
type="text"
4141
id="email"
42+
autoComplete="username"
4243
{...field.input}
4344
/>
4445
{field.meta.touched && field.meta.error && (
@@ -58,6 +59,7 @@ function LoginForm() {
5859
aria-label={t('LoginForm.PasswordARIA')}
5960
type="password"
6061
id="password"
62+
autoComplete="current-password"
6163
{...field.input}
6264
/>
6365
{field.meta.touched && field.meta.error && (

client/modules/User/components/NewPasswordForm.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ function NewPasswordForm(props) {
3535
aria-label={t('NewPasswordForm.TitleARIA')}
3636
type="password"
3737
id="Password"
38+
autoComplete="new-password"
3839
{...field.input}
3940
/>
4041
{field.meta.touched && field.meta.error && (
@@ -54,6 +55,7 @@ function NewPasswordForm(props) {
5455
type="password"
5556
aria-label={t('NewPasswordForm.ConfirmPasswordARIA')}
5657
id="confirm password"
58+
autoComplete="new-password"
5759
{...field.input}
5860
/>
5961
{field.meta.touched && field.meta.error && (

client/modules/User/components/SignupForm.jsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ function SignupForm() {
6262
aria-label={t('SignupForm.TitleARIA')}
6363
type="text"
6464
id="username"
65+
autoComplete="username"
6566
{...field.input}
6667
/>
6768
{field.meta.touched && field.meta.error && (
@@ -79,8 +80,9 @@ function SignupForm() {
7980
<input
8081
className="form__input"
8182
aria-label={t('SignupForm.EmailARIA')}
82-
type="text"
83+
type="email"
8384
id="email"
85+
autoComplete="email"
8486
{...field.input}
8587
/>
8688
{field.meta.touched && field.meta.error && (
@@ -100,6 +102,7 @@ function SignupForm() {
100102
aria-label={t('SignupForm.PasswordARIA')}
101103
type="password"
102104
id="password"
105+
autoComplete="new-password"
103106
{...field.input}
104107
/>
105108
{field.meta.touched && field.meta.error && (
@@ -119,6 +122,7 @@ function SignupForm() {
119122
type="password"
120123
aria-label={t('SignupForm.ConfirmPasswordARIA')}
121124
id="confirm password"
125+
autoComplete="new-password"
122126
{...field.input}
123127
/>
124128
{field.meta.touched && field.meta.error && (

0 commit comments

Comments
 (0)