Skip to content

Commit 8106c0c

Browse files
authored
Merge branch 'develop' into fixes-#2221/random-character-getting-deleted
2 parents 87d6acc + f946073 commit 8106c0c

File tree

20 files changed

+402
-401
lines changed

20 files changed

+402
-401
lines changed

client/modules/IDE/components/Editor/MobileEditor.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export const EditorContainer = styled.div`
99
transform: ${(props) =>
1010
props.expanded ? 'translateX(50%)' : 'translateX(0)'};
1111
12-
> header {
12+
> div {
1313
display: flex;
1414
${prop('MobilePanel.secondary')}
1515
> span {

client/modules/IDE/components/Editor/index.jsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,10 @@ class Editor extends React.Component {
208208
if (/^[a-z]$/i.test(e.key) && (mode === 'css' || mode === 'javascript')) {
209209
this.showHint(_cm);
210210
}
211+
if (e.key === 'Escape') {
212+
e.preventDefault();
213+
this._cm.getInputField().blur();
214+
}
211215
});
212216

213217
this._cm.getWrapperElement().style[
@@ -523,7 +527,7 @@ class Editor extends React.Component {
523527
{(matches) =>
524528
matches ? (
525529
<section className={editorSectionClass}>
526-
<header className="editor__header">
530+
<div className="editor__header">
527531
<button
528532
aria-label={this.props.t('Editor.OpenSketchARIA')}
529533
className="sidebar__contract"
@@ -548,7 +552,7 @@ class Editor extends React.Component {
548552
</span>
549553
<Timer />
550554
</div>
551-
</header>
555+
</div>
552556
<article
553557
ref={(element) => {
554558
this.codemirrorContainer = element;
@@ -565,7 +569,7 @@ class Editor extends React.Component {
565569
</section>
566570
) : (
567571
<EditorContainer expanded={this.props.isExpanded}>
568-
<header>
572+
<>
569573
<IconButton
570574
onClick={this.props.expandSidebar}
571575
icon={FolderIcon}
@@ -574,7 +578,7 @@ class Editor extends React.Component {
574578
{this.props.file.name}
575579
<UnsavedChangesIndicator />
576580
</span>
577-
</header>
581+
</>
578582
<section>
579583
<EditorHolder
580584
ref={(element) => {

client/modules/IDE/components/Header/Nav.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ const UnauthenticatedUserMenu = () => {
270270
</span>
271271
</Link>
272272
</li>
273-
<span className="nav__item-or">{t('Nav.LoginOr')}</span>
273+
<li className="nav__item-or">{t('Nav.LoginOr')}</li>
274274
<li className="nav__item">
275275
<Link to="/signup" className="nav__auth-button">
276276
<span className="nav__item-header" title="SignUp">

client/modules/IDE/components/Header/index.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ const Header = (props) => {
1212
const isMobile = useIsMobile();
1313

1414
return (
15-
<header>
15+
<>
1616
<Nav />
1717
{!isMobile && (
1818
<Toolbar syncFileContent={props.syncFileContent} key={project.id} />
1919
)}
20-
</header>
20+
</>
2121
);
2222
};
2323

client/modules/IDE/hooks/useSketchActions.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ const useSketchActions = () => {
1616
const unsavedChanges = useSelector((state) => state.ide.unsavedChanges);
1717
const authenticated = useSelector((state) => state.user.authenticated);
1818
const project = useSelector((state) => state.project);
19+
const user = useSelector((state) => state.user);
1920
const canEditProjectName = useSelector(selectCanEditSketch);
2021
const dispatch = useDispatch();
2122
const { t } = useTranslation();
@@ -40,8 +41,10 @@ const useSketchActions = () => {
4041
}
4142

4243
function downloadSketch() {
43-
dispatch(autosaveProject());
44-
exportProjectAsZip(project.id);
44+
if (authenticated && user.id === project.owner.id) {
45+
dispatch(autosaveProject());
46+
exportProjectAsZip(project.id);
47+
}
4548
}
4649

4750
function shareSketch() {

kubernetes_app.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ spec:
6565
selector:
6666
matchLabels:
6767
app: web-editor
68-
replicas: 3
68+
replicas: 4
6969
template:
7070
metadata:
7171
labels:
@@ -99,8 +99,8 @@ metadata:
9999
name: web-editor-node
100100
namespace: production
101101
spec:
102-
maxReplicas: 6
103-
minReplicas: 2
102+
maxReplicas: 9
103+
minReplicas: 3
104104
scaleTargetRef:
105105
apiVersion: extensions/v1beta1
106106
kind: Deployment

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "p5.js-web-editor",
3-
"version": "2.12.9",
3+
"version": "2.12.13",
44
"description": "The web editor for p5.js.",
55
"scripts": {
66
"clean": "rimraf dist",

0 commit comments

Comments
 (0)