Skip to content

Commit 7efafd4

Browse files
authored
Merge branch 'develop' into feature/urdu-translation
2 parents 1993403 + e77bc6a commit 7efafd4

File tree

6 files changed

+54
-29
lines changed

6 files changed

+54
-29
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Issues and Pull Requests categorized under the PATCH or MINOR Release Milestones
3838

3939
We will aim to deploy on a 1-2 month basis. Here are some dates we’re working towards:
4040

41-
2.11.0 MINOR Release: By December 22, 2023
41+
2.11.0 MINOR Release: By January 10, 2023
4242

4343
[You can read more about Semantic Versioning and the differences between a MINOR and PATCH release](https://semver.org/).
4444

client/modules/IDE/components/AddToCollectionList.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class CollectionList extends React.Component {
3939
props.getProject(props.projectId);
4040
}
4141

42-
this.props.getCollections(this.props.username);
42+
this.props.getCollections(this.props.user.username);
4343

4444
this.state = {
4545
hasLoadedData: false

client/modules/IDE/components/PreviewFrame.jsx

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const Frame = styled.iframe`
1111
border-width: 0;
1212
`;
1313

14-
function PreviewFrame({ fullView }) {
14+
function PreviewFrame({ fullView, isOverlayVisible }) {
1515
const iframe = useRef();
1616
const previewUrl = getConfig('PREVIEW_URL');
1717
useEffect(() => {
@@ -28,28 +28,36 @@ function PreviewFrame({ fullView }) {
2828
hid; microphone; magnetometer; midi; payment; usb; serial; vr; xr-spatial-tracking`;
2929

3030
return (
31-
<Frame
32-
title="sketch preview"
33-
src={frameUrl}
34-
sandbox={sandboxAttributes}
35-
allow={allow}
36-
scrolling="auto"
37-
allowtransparency
38-
allowpaymentrequest
39-
allowFullScreen
40-
frameBorder="0"
41-
ref={iframe}
42-
fullView={fullView}
43-
/>
31+
<>
32+
<div
33+
className="preview-frame-overlay"
34+
style={{ display: isOverlayVisible ? 'block' : 'none' }}
35+
/>
36+
<Frame
37+
title="sketch preview"
38+
src={frameUrl}
39+
sandbox={sandboxAttributes}
40+
allow={allow}
41+
scrolling="auto"
42+
allowtransparency
43+
allowpaymentrequest
44+
allowFullScreen
45+
frameBorder="0"
46+
ref={iframe}
47+
fullView={fullView}
48+
/>
49+
</>
4450
);
4551
}
4652

4753
PreviewFrame.propTypes = {
48-
fullView: PropTypes.bool
54+
fullView: PropTypes.bool,
55+
isOverlayVisible: PropTypes.bool
4956
};
5057

5158
PreviewFrame.defaultProps = {
52-
fullView: false
59+
fullView: false,
60+
isOverlayVisible: false
5361
};
5462

5563
export default PreviewFrame;

client/modules/IDE/pages/IDEView.jsx

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ const IDEView = () => {
173173
primary="second"
174174
size={ide.consoleIsExpanded ? consoleSize : 29}
175175
minSize={29}
176-
onChange={(size) => setConsoleSize(size)}
176+
onChange={(size) => {
177+
setConsoleSize(size);
178+
}}
177179
allowResize={ide.consoleIsExpanded}
178180
className="editor-preview-subpanel"
179181
>
@@ -191,16 +193,10 @@ const IDEView = () => {
191193
</h2>
192194
</header>
193195
<div className="preview-frame__content">
194-
<div
195-
className="preview-frame-overlay"
196-
style={{ display: isOverlayVisible ? 'block' : 'none' }}
196+
<PreviewFrame
197+
cmController={cmRef.current}
198+
isOverlayVisible={isOverlayVisible}
197199
/>
198-
<div>
199-
{((preferences.textOutput || preferences.gridOutput) &&
200-
ide.isPlaying) ||
201-
ide.isAccessibleOutputPlaying}
202-
</div>
203-
<PreviewFrame cmController={cmRef.current} />
204200
</div>
205201
</section>
206202
</SplitPane>
@@ -215,11 +211,18 @@ const IDEView = () => {
215211
split="horizontal"
216212
primary="second"
217213
minSize={200}
214+
onChange={() => {
215+
setIsOverlayVisible(true);
216+
}}
217+
onDragFinished={() => {
218+
setIsOverlayVisible(false);
219+
}}
218220
>
219221
<PreviewFrame
220222
fullView
221223
hide={!ide.isPlaying}
222224
cmController={cmRef.current}
225+
isOverlayVisible={isOverlayVisible}
223226
/>
224227
<Console />
225228
</SplitPane>

client/styles/components/_toolbar.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,6 @@
144144
.checkbox__autorefresh{
145145
cursor: pointer;
146146
@include themify(){
147-
color:getThemifyVariable('logo-color');
147+
accent-color:getThemifyVariable('logo-color');
148148
}
149149
}

contributor_docs/public_api.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,18 @@ You must provide the version number when accessing the API.
2929

3030
The API accepts and returns the following model objects, as JSON.
3131

32+
## Enabling Access Token UI in Settings Page
33+
34+
To enable the Access Token UI in the Settings page, follow these steps:
35+
36+
1. Navigate to the `.env` file in your project.
37+
2. Locate the line specifying UI_ACCESS_TOKEN_ENABLED.
38+
3. Set the value to `true`, as shown below:
39+
40+
```bash
41+
UI_ACCESS_TOKEN_ENABLED=true
42+
```
43+
3244
## Sketch
3345

3446
| Name | Type | Description |
@@ -217,3 +229,5 @@ No body
217229
|---------------|-------------------------|
218230
| 200 OK | Sketch has been deleted |
219231
| 404 Not Found | Sketch does not exist |
232+
233+

0 commit comments

Comments
 (0)