Skip to content

Commit 7e7c802

Browse files
authored
Merge branch 'develop' into fix/word-wrap-toggle-3475
2 parents 1a17912 + 0f10180 commit 7e7c802

File tree

5 files changed

+80
-11
lines changed

5 files changed

+80
-11
lines changed

.github/CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ The best way to verify if an issue is ready to be worked on is checking if it ha
7575

7676
### Before Submitting a Pull Request
7777
Before submitting a pull request, make sure that:
78+
- Your work is related to an issue. **Pull requests that do not have an associated issue will not be accepted.**
7879
- Your work adheres to the style guidelines and fits in with the rest of the codebase.
7980
- You ran the project locally and tested your changes. Pay special attention to any specific areas of the p5.js editor that may be affected by your changes. Does everything still work as before? Great!
8081
- You reference the [Preparing a Pull Request Guide](https://github.com/processing/p5.js-web-editor/blob/develop/contributor_docs/preparing_a_pull_request.md) for more details!

contributor_docs/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ These guides aren't exhaustive, and do not cover all the possible ways you can c
99
* [Installation](installation.md) - A guide for setting up your development environment.
1010
* [Development](development.md) - A guide for contributing code to the codebase.
1111
* [Testing](./testing.md) - A guide for writing and running tests in the codebase.
12-
* [Preparing a pull-request](preparing_a_pull_request.md) - Instructions for making a pull-request.
12+
* [Preparing an Issue](preparing_an_issue.md) - Instructions for creating and navigating issues.
13+
* [Preparing a Pull Request](preparing_a_pull_request.md) - Instructions for making a pull-request.
1314
* [Accessibility Guidelines](accessibility.md) - Guidelines for writing code to create an accessible application.
1415
* [Translations Guidelines](translations.md) - Guidelines for translating the p5.js editor.
1516
* [Deployment](deployment.md) - A guide to production deployment, and all platforms that are being used.
@@ -18,5 +19,4 @@ These guides aren't exhaustive, and do not cover all the possible ways you can c
1819

1920
## Documents to Create
2021
* Software Design Principles - reference [p5.js software design principles](https://github.com/processing/p5.js/blob/eb61f7a260531d17930de3c987949558ce242d35/contributor_docs/contributor_guidelines.md#software-design-principles)
21-
* Issue Templates - reference [p5.js issue templates](https://github.com/processing/p5.js/blob/main/contributor_docs/contributor_guidelines.md#issue-templates)
2222
* File Structure - An explanation of the file structure of this application.

contributor_docs/preparing_a_pull_request.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,17 @@
1-
# Preparing a pull request
1+
# Preparing a Pull Request
22

33
Copied and updated from the [p5.js repository](https://github.com/processing/p5.js).
44

5-
Pull-requests are easier when your code is up to date! You can use git rebase to update your code to incorporate changes from other contributors. Here's how.
5+
Pull-requests are easier when your code is up to date!
6+
7+
## Before Submitting a Pull Request
8+
Before submitting a pull request, make sure that:
9+
10+
- Your work is related to an issue. **Pull requests that do not have an associated issue will not be accepted.**
11+
- Your work adheres to the style guidelines and fits in with the rest of the codebase.
12+
- You ran the project locally and tested your changes. Pay special attention to any specific areas of the p5.js editor that may be affected by your changes. Does everything still work as before? Great!
13+
14+
Once that's done, you can use git rebase to update your code to incorporate changes from other contributors. Here's how.
615

716
## Save and Update
817

@@ -40,6 +49,9 @@ Then ask git about the latest changes.
4049
### Verifies what git will be committing
4150
git status
4251

52+
## Pull Request Templates
53+
Once you've opened your pull request, please ensure that you follow the guidelines and
54+
4355
## CONFLICTS
4456
You may have some conflicts! It's okay. Feel free to ask for help. If merging with the latest upstream `develop` branch causes conflicts, you can always make a pull request with the upstream repository, which makes the merge conflicts public.
4557

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
# Preparing an Issue
2+
3+
Most activity on the p5.js Editor’s GitHub happens in issues. Issues are GitHub posts which can contain bug reports, feature requests, or broader discussions about the development of the p5.js Editor. It’s a great place to begin contributing.
4+
5+
## Filing a New Issue
6+
7+
To file a new issue:
8+
9+
1. Visit the [Issues](https://github.com/processing/p5.js-web-editor/issues) tab on the repository.
10+
11+
2. Click the green 'New Issue' button on the right.
12+
13+
3. A modal should appear with several templates for the type of issue you would like to open. Choose the one that best matches what you're looking for (i.e Bug Report, Feature Request).
14+
15+
4. Fill out the form as in-depth as you can. It helps to be as clear and specific as you can in your language and supporting information. Some ways to achieve that is by including screenshots, code snippets, or steps to exactly reproduce a scenario! Doing this helps maintainers and other contributors understand and respond to your issue more quickly and accurately.
16+
17+
More in-depth information about filing an issue can be found within the [p5.js Library Documentation for Issue Templates](https://github.com/processing/p5.js/blob/main/contributor_docs/contributor_guidelines.md#issue-templates).
18+
19+
## Navigating Existing Issues
20+
21+
### Project Board
22+
Many issues are related to each other and fall under bigger projects. To get a bigger picture, look at the [All Projects](https://github.com/processing/p5.js-web-editor/projects/) board.
23+
24+
### Searching and Filtering
25+
If you're looking for issues to work on, a good place to start is with tickets labeled [high priority](https://github.com/processing/p5.js-web-editor/labels/priority%3Ahigh). You can also look for tickets that are [feature enhancements](https://github.com/processing/p5.js-web-editor/labels/type%3Afeature), [bug fixes](https://github.com/processing/p5.js-web-editor/labels/type%3Abug), and a few other tags.
26+
27+
If you feel like an issue is tagged incorrectly (e.g. it's low priority and you think it should be high), please update the issue!
28+
29+
---
30+
31+
## Understanding Issue Labels
32+
33+
Labels help categorize issues and makes them easier to find and sort. You can browse the full list in our [Issue Labels](https://github.com/processing/p5.js-web-editor/labels), but here are a few helpful ones to understand early on:
34+
35+
### Good First Issues
36+
For first-time contributors or those who want to start with a small task, [check out the list of good first issues](https://github.com/processing/p5.js-web-editor/labels/good%20first%20issue), or [issues that need documentation of steps to reproduce](https://github.com/processing/p5.js-web-editor/issues?q=is%3Aissue+is%3Aopen+label%3A%22needs+steps+to+reproduce%22). It's okay to not know how to fix an issue—feel free to ask questions about to approach the problem!
37+
38+
### Good Medium Issues
39+
If you're looking for a bigger project to take on, look through the issues tagged [good medium issue](https://github.com/processing/p5.js-web-editor/labels/good%20medium%20issue). These issues are self-contained projects that may take longer to work on, but are great if you're looking to get more deeply involved in contributing!
40+
41+
### Awaiting Maintainer Approval
42+
All new issues opened on the p5.js editor repository will automatically have the 'Awaiting Maintainer Approval' label. This means that the issue needs review or confirmation from a maintainer before moving forward.
43+
44+
If you see an issue with this label, it's best to hold off on development until it's been approved and has the 'Ready for Work' label.
45+
46+
### Ready for Work
47+
This label means the issue has been reviewed and is ready to be picked up! If it's not assigned to anyone yet, you can leave a comment expressing your interest and asked to be assigned.
48+
49+
If you see an issue that does not have this label but you feel that it might be ready for development, feel free to comment on it!
50+
51+
### Help Wanted
52+
53+
These issues need additional input, ideas, or code contributions from the community. If you're looking to get involved, this is also a great place to start.

contributor_docs/translations.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
# Translations Guidelines
22

3+
Translations are a great way to get started with contributing, and plays a big role in making the p5.js editor and its documentation more accessible.
34

4-
*How to contribute with Translations for p5 web editor*
5-
6-
## General rules of thumb for translations
5+
Below are some general rules of thumb to keep in mind when contributing translations:
76

8-
In order to simplify the translations process the following rules of thumb were used:
7+
## What Can I Translate?
8+
If you're interested in translations, here's how to get started:
9+
- Please only translate languages **you speak fluently or natively**.
10+
- At this time, we do not accept machine-generated translations (i.e from Google Translate), as they often lack context or accuracy.
11+
- You can also start with reviewing or improving existing translations in languages you're familiar with as well!
912

10-
## Technical Part
13+
## How Can I Add Translations in the Codebase?
1114

1215
* There is only one file to translate all the texts in any specific language, which is located under the directory, in the respective locale [subdirectory](https://github.com/processing/p5.js-web-editor/tree/develop/translations/locales)
1316
* The new language code must be added to [client/i18n.js](https://github.com/processing/p5.js-web-editor/blob/edae248eede21d7ad7702945929efbcdfeb4d9ea/client/i18n.js#L22)
@@ -55,7 +58,7 @@ export function languageKeyToLabel(lang) {
5558
}
5659
```
5760

58-
## Translations
61+
## Handling Translations Files
5962

6063
* Every component should introduce its own subset of keys inside a dictionary named after the component.
6164
For instance: If you want to translate AssetList.jsx you need to introduce the following namespace in translations.json :
@@ -92,5 +95,5 @@ Did you want to know the context?
9295

9396
Thanks!
9497

95-
P5.js Web Editor Community
98+
p5.js Editor Community
9699

0 commit comments

Comments
 (0)